Skip to content

Commit

Permalink
fix: FeastExtrasDependencyImportError when using SparkOfflineStore wi…
Browse files Browse the repository at this point in the history
…thout S3 (feast-dev#4594)

* Import aws_utils only if using s3.

Signed-off-by: Aloysius Lim <aloysius.lim@cuezen.com>

* Lint.

Signed-off-by: Aloysius Lim <aloysius.lim@cuezen.com>

---------

Signed-off-by: Aloysius Lim <aloysius.lim@cuezen.com>
  • Loading branch information
aloysius-lim authored Oct 2, 2024
1 parent 30603a2 commit 1ba94f7
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
RetrievalMetadata,
)
from feast.infra.registry.base_registry import BaseRegistry
from feast.infra.utils import aws_utils
from feast.repo_config import FeastConfigBaseModel, RepoConfig
from feast.saved_dataset import SavedDatasetStorage
from feast.type_map import spark_schema_to_np_dtypes
Expand Down Expand Up @@ -399,6 +398,8 @@ def to_remote_storage(self) -> List[str]:

return _list_files_in_folder(output_uri)
elif self._config.offline_store.staging_location.startswith("s3://"):
from feast.infra.utils import aws_utils

spark_compatible_s3_staging_location = (
self._config.offline_store.staging_location.replace(
"s3://", "s3a://"
Expand Down

0 comments on commit 1ba94f7

Please sign in to comment.