Skip to content

Commit

Permalink
fix: Update react-router-dom to 6.3.0 and restrict its version in Fea…
Browse files Browse the repository at this point in the history
…st UI (feast-dev#4556)

As noted in feast-dev#3794, Feast UI is not compatible with latest react-router-dom
versions, more precisely from 6.4.0 onwards. Limit react-router-dom version
to a compatible range to avoid the runtime errors mentioned in the issue
when installing peer dependencies without specifying exact versions.

After setting the restricted versions, `yarn install` updated
`react-router-dom` to the latest compatible version 6.3.0. It should be a
minor upgrade (https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v630),
and I didn't notice anything not working in the UI after it.

Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
  • Loading branch information
peruukki authored Sep 22, 2024
1 parent f308572 commit 4293608
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-query": "^3.34.12",
"react-router-dom": "6",
"react-router-dom": "<6.4.0",
"react-scripts": "^5.0.0",
"use-query-params": "^1.2.3",
"zod": "^3.11.6"
Expand All @@ -37,7 +37,7 @@
"query-string": "^7.1.1",
"react-code-blocks": "^0.0.9-0",
"react-query": "^3.34.12",
"react-router-dom": "6",
"react-router-dom": "<6.4.0",
"react-scripts": "^5.0.0",
"tslib": "^2.3.1",
"use-query-params": "^1.2.3",
Expand Down
18 changes: 9 additions & 9 deletions ui/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9345,18 +9345,18 @@ react-remove-scroll@^2.5.2:
use-callback-ref "^1.3.0"
use-sidecar "^1.1.2"

react-router-dom@6:
version "6.2.1"
resolved "https://registry.yarnpkg.com/react-router-dom/-/react-router-dom-6.2.1.tgz#32ec81829152fbb8a7b045bf593a22eadf019bec"
integrity sha512-I6Zax+/TH/cZMDpj3/4Fl2eaNdcvoxxHoH1tYOREsQ22OKDYofGebrNm6CTPUcvLvZm63NL/vzCYdjf9CUhqmA==
react-router-dom@<6.4.0:
version "6.3.0"
resolved "https://registry.yarnpkg.com/react-router-dom/-/react-router-dom-6.3.0.tgz#a0216da813454e521905b5fa55e0e5176123f43d"
integrity sha512-uaJj7LKytRxZNQV8+RbzJWnJ8K2nPsOOEuX7aQstlMZKQT0164C+X2w6bnkqU3sjtLvpd5ojrezAyfZ1+0sStw==
dependencies:
history "^5.2.0"
react-router "6.2.1"
react-router "6.3.0"

react-router@6.2.1:
version "6.2.1"
resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.2.1.tgz#be2a97a6006ce1d9123c28934e604faef51448a3"
integrity sha512-2fG0udBtxou9lXtK97eJeET2ki5//UWfQSl1rlJ7quwe6jrktK9FCCc8dQb5QY6jAv3jua8bBQRhhDOM/kVRsg==
react-router@6.3.0:
version "6.3.0"
resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.3.0.tgz#3970cc64b4cb4eae0c1ea5203a80334fdd175557"
integrity sha512-7Wh1DzVQ+tlFjkeo+ujvjSqSJmkt1+8JO+T5xklPlgrh70y7ogx75ODRW0ThWhY7S+6yEDks8TYrtQe/aoboBQ==
dependencies:
history "^5.2.0"

Expand Down

0 comments on commit 4293608

Please sign in to comment.