Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some missed navbar icons, and adjusted for last version #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

arturmamedov
Copy link

added !important also after all content: ''; override, cause for me on elfinder v2.1.10 it not shown

Copy link
Owner

@lokothodida lokothodida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the project! Please excuse me for getting back to you so late on this - I haven't properly looked at my old repositories in a while. I've only got concerns with one icon. Once that is fixed, it is changed, build the project (npm run build), commit the built css file and I'll be happy to merge your changes in 👍

moono/css/navbar-icons.less Outdated Show resolved Hide resolved
@arturmamedov
Copy link
Author

@lokothodida okay man, i build less file's to theme.css, i see that not only my changes wasn't yet builded but is all okay, i test the theme and it work fine!

But for me, maybe because i add CSS file simply in head tag and not with elFinder import, i must to add !important for all icons

@arturmamedov
Copy link
Author

arturmamedov commented Jul 11, 2019

Also for me i encrease the icon size in grid view, if u like it i can add this change to.

Now
immagine

After
immagine

This is for another PR if u want, and also the thumbnails are hidden in your version, i can make a PR for correct this thing:
immagine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants