Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with other plugins accessing $data_index object as a SimpleXML object #14

Closed
lokothodida opened this issue Feb 5, 2017 · 0 comments
Labels

Comments

@lokothodida
Copy link
Owner

lokothodida commented Feb 5, 2017

Example

I18N Special Pages has a getFields method which expects the $data_index object to be a SimpleXML object:

    // i18n_specialpages/specialpages.class.php
    // at roughly line 275 ($data is $data_index)
      foreach ($data->children() as $child) {
        if (!in_array($child->getName(), $stdfields) && (string) $child) {
          $fields[$child->getName()] = (string) $child;
        }
      }

The current FrontRouter code makes $data_index a plain object by merging two (cast) arrays, so the merge should instead just bolt these properties on, instead of doing a full merge.

lokothodida added a commit that referenced this issue Feb 5, 2017
@lokothodida lokothodida added the bug label Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant