perf: avoid effect multiple runs (melt-ui#1089)

Co-authored-by: Hunter Johnston <johnstonhuntera@gmail.com> Co-authored-by: Hunter Johnston <64506580+huntabyte@users.noreply.github.com>
lolcabanon · Apr 20, 2024 · 0e454dc · 0e454dc
1 parent 5654d84
commit 0e454dc
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/silly-eels-search.md b/.changeset/silly-eels-search.md
@@ -0,0 +1,5 @@
+---
+"@melt-ui/svelte": patch
+---
+
+performance: avoid effect multiple runs
diff --git a/src/lib/builders/listbox/create.ts b/src/lib/builders/listbox/create.ts
@@ -212,7 +212,7 @@ export function createListbox<
 		if (!triggerEl) return;
 
 		// The active trigger is used to anchor the menu to the input element.
-		activeTrigger.set(triggerEl);
+		if (triggerEl !== activeTrigger.get()) activeTrigger.set(triggerEl);
 
 		// Wait a tick for the menu to open then highlight the selected item.
 		await tick();

diff --git a/src/lib/builders/popover/create.ts b/src/lib/builders/popover/create.ts
@@ -19,6 +19,7 @@ import {
 	toWritableStores,
 	portalAttr,
 	generateIds,
+	withGet,
 } from '$lib/internal/helpers/index.js';
 
 import {
@@ -79,7 +80,7 @@ export function createPopover(args?: CreatePopoverProps) {
 	const openWritable = withDefaults.open ?? writable(withDefaults.defaultOpen);
 	const open = overridable(openWritable, withDefaults?.onOpenChange);
 
-	const activeTrigger = writable<HTMLElement | null>(null);
+	const activeTrigger = withGet.writable<HTMLElement | null>(null);
 
 	const ids = toWritableStores({ ...generateIds(popoverIdParts), ...withDefaults.ids });
 
@@ -184,7 +185,7 @@ export function createPopover(args?: CreatePopoverProps) {
 		open.update((prev) => {
 			return !prev;
 		});
-		if (triggerEl) {
+		if (triggerEl && triggerEl !== activeTrigger.get()) {
 			activeTrigger.set(triggerEl);
 		}
 	}