fix: Range Calendar/Picker single day range selection (melt-ui#1037)

lolcabanon · Apr 20, 2024 · b9d9ba3 · b9d9ba3
1 parent 780ced0
commit b9d9ba3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/curly-olives-trade.md b/.changeset/curly-olives-trade.md
@@ -0,0 +1,5 @@
+---
+'@melt-ui/svelte': patch
+---
+
+Range Calendar/Picker: fixed bug preventing a range with the same start and end date (Closes #898)
diff --git a/src/lib/builders/date-range-field/create.ts b/src/lib/builders/date-range-field/create.ts
@@ -6,6 +6,7 @@ import {
 	getDefaultDate,
 	getFirstSegment,
 	isBefore,
+	isBeforeOrSame,
 } from '$lib/internal/helpers/date/index.js';
 import {
 	addMeltEventListener,
@@ -154,7 +155,7 @@ export function createDateRangeField(props?: CreateDateRangeFieldProps) {
 				return false;
 			}
 
-			if (!isBefore($value?.start, $value?.end)) {
+			if (!isBeforeOrSame($value?.start, $value?.end)) {
 				return true;
 			}
 

diff --git a/src/lib/builders/range-calendar/create.ts b/src/lib/builders/range-calendar/create.ts
@@ -784,8 +784,9 @@ export function createRangeCalendar<T extends DateValue = DateValue>(
 			}
 		}
 
-		if ($startValue && isSameDay($startValue, date) && !preventDeselect.get() && !$endValue) {
+		if ($startValue && $endValue && isSameDay($endValue, date) && !preventDeselect.get()) {
 			startValue.set(undefined);
+			endValue.set(undefined);
 			placeholder.set(date);
 			announcer.announce('Selected date is now empty.', 'polite');
 			return;