feat: Added tflint as pre-commit hook (terraform-aws-modules#507)

.pre-commit-config.yaml

@@ -1,10 +1,13 @@
 repos:
 - repo: git://github.com/antonbabenko/pre-commit-terraform
-  rev: v1.31.0
+  rev: v1.40.0
   hooks:
     - id: terraform_fmt
     - id: terraform_docs
+    - id: terraform_tflint
+      args:
+        - '--args=--config=__GIT_WORKING_DIR__/.tflint.hcl'
 - repo: git://github.com/pre-commit/pre-commit-hooks
-  rev: v3.1.0
+  rev: v3.2.0
   hooks:
     - id: check-merge-conflict

.tflint.hcl

@@ -0,0 +1,57 @@
+config {
+  deep_check = false
+  ignore_module = {}
+  varfile = []
+}
+
+rule "terraform_deprecated_interpolation" {
+  enabled = true
+}
+
+rule "terraform_deprecated_index" {
+  enabled = true
+}
+
+rule "terraform_unused_declarations" {
+  enabled = true
+}
+
+rule "terraform_comment_syntax" {
+  enabled = true
+}
+
+rule "terraform_documented_outputs" {
+  enabled = true
+}
+
+rule "terraform_documented_variables" {
+  enabled = true
+}
+
+rule "terraform_typed_variables" {
+  enabled = true
+}
+
+rule "terraform_module_pinned_source" {
+  enabled = true
+}
+
+rule "terraform_naming_convention" {
+  enabled = true
+}
+
+rule "terraform_required_version" {
+  enabled = true
+}
+
+rule "terraform_required_providers" {
+  enabled = true
+}
+
+rule "terraform_standard_module_structure" {
+  enabled = true
+}
+
+rule "terraform_workspace_remote" {
+  enabled = true
+}

examples/complete-vpc/README.md

@@ -19,13 +19,16 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| aws | n/a |
+| aws | >= 2.68, < 4.0 |
 
 ## Inputs
 

examples/complete-vpc/outputs.tf

@@ -67,20 +67,3 @@ output "this_customer_gateway" {
   description = "Map of Customer Gateway attributes"
   value       = module.vpc.this_customer_gateway
 }
-
-//
-//# VPC endpoints
-//output "vpc_endpoint_ec2_id" {
-//  description = "The ID of VPC endpoint for EC2"
-//  value       = "${module.vpc.vpc_endpoint_ec2_id}"
-//}
-//
-//output "vpc_endpoint_ec2_network_interface_ids" {
-//  description = "One or more network interfaces for the VPC Endpoint for EC2."
-//  value = ["${module.vpc.vpc_endpoint_ec2_network_interface_ids}"]
-//}
-//
-//output "vpc_endpoint_ec2_dns_entry" {
-//  description = "The DNS entries for the VPC Endpoint for EC2."
-//  value = ["${module.vpc.vpc_endpoint_ec2_dns_entry}"]
-//}

examples/complete-vpc/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/ipv6/README.md

@@ -17,13 +17,16 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 
 | Name | Version |
 |------|---------|
-| aws | n/a |
+| aws | >= 2.68, < 4.0 |
 
 ## Inputs
 

examples/ipv6/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/issue-108-route-already-exists/README.md

@@ -21,7 +21,10 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 

examples/issue-108-route-already-exists/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/issue-44-asymmetric-private-subnets/README.md

@@ -19,7 +19,10 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 

examples/issue-44-asymmetric-private-subnets/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/issue-46-no-private-subnets/README.md

@@ -19,7 +19,10 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 

examples/issue-46-no-private-subnets/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/manage-default-vpc/README.md

@@ -19,7 +19,10 @@ Run `terraform destroy` when you don't need these resources.
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 

examples/manage-default-vpc/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/network-acls/README.md

@@ -21,7 +21,10 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 

examples/network-acls/outputs.tf

@@ -10,11 +10,6 @@ output "vpc_cidr_block" {
   value       = module.vpc.vpc_cidr_block
 }
 
-//output "vpc_ipv6_cidr_block" {
-//  description = "The IPv6 CIDR block"
-//  value       = ["${module.vpc.vpc_ipv6_cidr_block}"]
-//}
-
 # Subnets
 output "private_subnets" {
   description = "List of IDs of private subnets"

examples/network-acls/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/secondary-cidr-blocks/README.md

@@ -19,7 +19,10 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 

examples/secondary-cidr-blocks/versions.tf

@@ -0,0 +1,7 @@
+terraform {
+  required_version = ">= 0.12.7, < 0.14"
+
+  required_providers {
+    aws = ">= 2.68, < 4.0"
+  }
+}

examples/simple-vpc/README.md

@@ -23,13 +23,14 @@ Note that this example may create resources which can cost money (AWS Elastic IP
 <!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| terraform | >= 0.12.7, < 0.14 |
+| aws | >= 2.68, < 4.0 |
 
 ## Providers
 
-| Name | Version |
-|------|---------|
-| aws | n/a |
+No provider.
 
 ## Inputs
 

examples/simple-vpc/main.tf

@@ -2,11 +2,6 @@ provider "aws" {
   region = "eu-west-1"
 }
 
-data "aws_security_group" "default" {
-  name   = "default"
-  vpc_id = module.vpc.vpc_id
-}
-
 module "vpc" {
   source = "../../"