Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Editorial updates to the backup and restore section #856

Closed
wants to merge 1 commit into from
Closed

[doc] Editorial updates to the backup and restore section #856

wants to merge 1 commit into from

Conversation

asettle
Copy link

@asettle asettle commented Jan 18, 2024

Editing and cleaning up the language in the backup and restore section.

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

Edits are always wonderful

Special notes for your reviewer:

Note: Clarity on the "blocking way" would be appreciated

Additional documentation or context

@asettle
[doc] Editorial updates to the backup and restore section
3582806 
Editing and cleaning up the language in the backup and restore section.

Note: Clarity on the "blocking style" would be appreciated

Signed-off-by: Alexandra Settle <asettle@suse.com>
@asettle asettle requested a review from a team as a code owner January 18, 2024 05:33
@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024

✅ Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 3582806
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/65a8b818ea76bc00078e8c64
😎 Deploy Preview https://deploy-preview-856--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@innobead innobead self-requested a review January 18, 2024 13:38
innobead
innobead requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please also help update active versions (1.4.4) and the upcoming 1.6.0, 1.54 and 1.4.5.

@innobead
Copy link
Member

LGTM.

Please also help update active versions (1.4.4) and the upcoming 1.6.0, 1.54 and 1.4.5.

@jillian-maroket can you just help with this? thanks.

@innobead
Copy link
Member

@jillian-maroket as I mentioned above, please continue this PR, as @asettle seems not finishing this yet.

@jillian-maroket
Copy link
Contributor

@innobead Sorry, your comment was missed. I'm working on some time-sensitive Harvester tasks so I'll revisit this once those are completed.

@innobead
Copy link
Member

@innobead Sorry, your comment was missed. I'm working on some time-sensitive Harvester tasks so I'll revisit this once those are completed.

@jillian-maroket find time, so we can wrap up this.

derekbit
derekbit approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

derekbit commented Jul 6, 2024

ping @jillian-maroket

@jillian-maroket jillian-maroket mentioned this pull request Jul 7, 2024
Merged
@jillian-maroket
Copy link
Contributor

I could not work with Alex's branch so I created a new PR. The suggested changes were applied as is to all active versions.

@derekbit
Copy link
Member

derekbit commented Jul 8, 2024

Already addressed in #939. Thanks for your contribution.

@derekbit derekbit closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead requested changes

@derekbit derekbit derekbit approved these changes

@jillian-maroket jillian-maroket jillian-maroket approved these changes

Assignees

@asettle asettle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asettle @innobead @jillian-maroket @derekbit