Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(storage-network): support RWX volumes #911

Merged

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8184

What this PR does / why we need it:

Add storage Network Support for Read-Write-Many (RWX) Volume.

Special notes for your reviewer:

None

Additional documentation or context

longhorn/longhorn#8616

@c3y1huang c3y1huang self-assigned this May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 0a12de0
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/6690c146b911b60008f538c8
😎 Deploy Preview https://deploy-preview-911--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@c3y1huang c3y1huang force-pushed the feat-storage-network-for-rwx-volumes branch 2 times, most recently from 0e66d16 to 9ecbcd6 Compare June 3, 2024 04:28
@c3y1huang c3y1huang force-pushed the feat-storage-network-for-rwx-volumes branch 6 times, most recently from 8a3eccb to e40aafa Compare June 3, 2024 09:27
@c3y1huang c3y1huang marked this pull request as ready for review June 3, 2024 09:27
@c3y1huang c3y1huang requested a review from a team as a code owner June 3, 2024 09:27
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

content/docs/1.7.0/deploy/important-notes/index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/references/settings.md Outdated Show resolved Hide resolved
@c3y1huang
Copy link
Contributor Author

c3y1huang commented Jun 6, 2024

Converting this to draft as we are thinking of introducing a new setting that could change the behavior of the feature. Once the new settings are finalized, this PR will be out for review again.

longhorn/longhorn#8710

cc @jillian-maroket

@c3y1huang c3y1huang marked this pull request as draft June 6, 2024 06:29
@c3y1huang c3y1huang force-pushed the feat-storage-network-for-rwx-volumes branch 13 times, most recently from cbe10fa to 9ff3693 Compare June 6, 2024 09:39
@c3y1huang c3y1huang force-pushed the feat-storage-network-for-rwx-volumes branch from 9ff3693 to b55ef8c Compare June 6, 2024 09:40
@c3y1huang c3y1huang force-pushed the feat-storage-network-for-rwx-volumes branch from b55ef8c to 27f0441 Compare July 10, 2024 05:47
@c3y1huang c3y1huang marked this pull request as ready for review July 10, 2024 05:51
@c3y1huang
Copy link
Contributor Author

@jillian-maroket this is ready for review again.

@jillian-maroket
Copy link
Contributor

@c3y1huang I'll review this tomorrow because I'm supposed to finish a Harvester task today.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

content/docs/1.7.0/deploy/important-notes/index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/deploy/important-notes/index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/deploy/important-notes/index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/deploy/important-notes/index.md Outdated Show resolved Hide resolved
content/docs/1.7.0/references/settings.md Outdated Show resolved Hide resolved
longhorn/longhorn-8184

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the feat-storage-network-for-rwx-volumes branch from 27f0441 to 0a12de0 Compare July 12, 2024 05:38
@c3y1huang c3y1huang merged commit e024eb4 into longhorn:master Jul 12, 2024
6 checks passed
@c3y1huang c3y1huang deleted the feat-storage-network-for-rwx-volumes branch July 12, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants