Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(1.7.0): add Replica Auto Balance Disk Pressure Threshold setting #924

Merged
merged 2 commits into from
Jul 5, 2024
Merged

doc(1.7.0): add Replica Auto Balance Disk Pressure Threshold setting #924

merged 2 commits into from
Jul 5, 2024

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang commented Jun 24, 2024 •
edited
Loading

Which issue(s) this PR fixes:

Issue longhorn/longhorn#4105

What this PR does / why we need it:

Add a new Replica Auto Balance Disk Pressure Threshold setting.

Special notes for your reviewer:

Additional documentation or context

longhorn/longhorn#7576

@c3y1huang c3y1huang self-assigned this Jun 24, 2024
@c3y1huang c3y1huang mentioned this pull request Jun 24, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

✅ Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit ce892f6
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/6687b2f7039d2000083d67a6
😎 Deploy Preview https://deploy-preview-924--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from 7d18104 to cc30c05 Compare July 5, 2024 00:36
@c3y1huang c3y1huang marked this pull request as ready for review July 5, 2024 00:36
@c3y1huang c3y1huang requested a review from a team as a code owner July 5, 2024 00:36
jillian-maroket
jillian-maroket reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

content/docs/1.7.0/references/settings.md Outdated Show resolved Hide resolved
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from cc30c05 to 975c75b Compare July 5, 2024 02:51
@c3y1huang
Copy link
Contributor Author

@jillian-maroket the suggestion looks good to me. I've added more statements, PTAL, thank you!

jillian-maroket
jillian-maroket reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

content/docs/1.7.0/references/settings.md Outdated Show resolved Hide resolved
content/docs/1.7.0/references/settings.md Outdated Show resolved Hide resolved
content/docs/1.7.0/references/settings.md Outdated Show resolved Hide resolved
@c3y1huang
doc(1.7.0): add Replica Auto Balance Disk Pressure Threshold setting
09b2dcd 
longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from 975c75b to 09b2dcd Compare July 5, 2024 07:36
@derekbit
Copy link
Member

derekbit commented Jul 5, 2024

@c3y1huang
Can we add a section describing the feature in https://longhorn.io/docs/1.7.0/nodes-and-volumes/nodes/scheduling/?

@c3y1huang
Copy link
Contributor Author

c3y1huang commented Jul 5, 2024 •
edited
Loading

@c3y1huang Can we add a section describing the feature in https://longhorn.io/docs/1.7.0/nodes-and-volumes/nodes/scheduling/?

This page seems to describe general replica scheduling, but this feature is under the scope of replica-auto-balance setting specifically when the value is set to best-effort. So I don't think we should include it there.

Maybe we can add a section in https://longhorn.io/docs/1.7.0/high-availability/auto-balance-replicas/. What do you think?

@derekbit
Copy link
Member

derekbit commented Jul 5, 2024

@c3y1huang Can we add a section describing the feature in https://longhorn.io/docs/1.7.0/nodes-and-volumes/nodes/scheduling/?

This page seems to describe general replica scheduling, but this feature is under the scope of replica-auto-balance setting specifically when the value is set to best-effort. So I don't think we should include it there.

Maybe we can add a section in https://longhorn.io/docs/1.7.0/high-availability/auto-balance-replicas/. What do you think?

Yeah, sounds good to me!

@c3y1huang c3y1huang requested a review from derekbit July 5, 2024 08:40
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from bab0205 to d824a64 Compare July 5, 2024 08:43
@c3y1huang c3y1huang requested a review from derekbit July 5, 2024 08:44
@c3y1huang
doc(1.7.0): add Replica Auto Balance Disk Pressure Threshold to aut…
ce892f6 
…o balance replicas

longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from d824a64 to ce892f6 Compare July 5, 2024 08:46
@c3y1huang c3y1huang requested a review from derekbit July 5, 2024 08:47
derekbit
derekbit approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 04aa8ef into longhorn:master Jul 5, 2024
6 checks passed
@c3y1huang c3y1huang deleted the feat-auto-balance-node-disks branch July 5, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@jillian-maroket jillian-maroket Awaiting requested review from jillian-maroket

Assignees

@c3y1huang c3y1huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c3y1huang @derekbit @jillian-maroket