Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reference longhorn namespace for installation daemonsets #932

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

samtudor0112
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8855

What this PR does / why we need it:

Old exemplar commands won't work once namespace is changed

Special notes for your reviewer:

Additional documentation or context

longhorn/longhorn#8856

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 23a3fa7
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66adf36337083f0008d60186
😎 Deploy Preview https://deploy-preview-932--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jillian-maroket
Copy link
Contributor

@derekbit Please check the suggested change. Thanks!

Signed-off-by: Sam Tudor <samueltudor@hotmail.com>
Signed-off-by: Sam Tudor <samueltudor@hotmail.com>
@samtudor0112
Copy link
Contributor Author

The code change associated with this PR has now been merged. This PR now needs to be merged before the 1.6.3 release otherwise the docs will be incorrect. Please review and approve. Thanks!

@derekbit
Copy link
Member

derekbit commented Aug 3, 2024

Hello @samtudor0112
Let's put the change in v1.8.0. I will merge it after releasing v1.7.0 GA. Thank you.

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 276c3b4 into longhorn:master Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants