Don't display unknown diplomatic relations as war #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diplomatic status between two nations the current player has no contact with is usually not known by the client. The server sends "war" in this case (it should arguably not send anything at all). It also sets the NI_DIPLOMACY bit in client.visible to false to tell the client that this information is not available. However, the client ignores this and just displays "war". Make the client ignore diplomatic relations between two players when the NI_DIPLOMACY bit is false for both players -- that is, when no information is available. This prevents the client from displaying invalid data. Discovered during LeagueB2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diplomatic status between two nations the current player has no contact with is usually not known by the client. The server sends "war" in this case (it should arguably not send anything at all). It also sets the NI_DIPLOMACY bit in client.visible to false to tell the client that this information is not available. However, the client ignores this and just displays "war".
Make the client ignore diplomatic relations between two players when the NI_DIPLOMACY bit is false for both players -- that is, when no information is available. This prevents the client from displaying invalid data.
Discovered during LeagueB2.
Backport candidate (I confirmed that
stablealready has theNationalIntelligencefeature that this patch requires)