Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build.yaml to use clang-format-18 #2456

Closed
wants to merge 3 commits into from

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Dec 12, 2024

Closes #2417

@jwrober jwrober requested a review from lmoureaux December 12, 2024 16:59
@lmoureaux
Copy link
Contributor

Will need to reformat the code as well

@jwrober
Copy link
Collaborator Author

jwrober commented Dec 12, 2024

The instructions for the action says that the check only tests the changes in the PR. So I wasn't thinking that we needed to reformat the whole tree.

@blabber blabber closed this Dec 12, 2024
@blabber blabber reopened this Dec 12, 2024
@blabber
Copy link
Collaborator

blabber commented Dec 12, 2024

Commandline to bulk reformat the code (excluding dependencies). clang-format18 is the name of the tool in FreeBSD, adapt as needed.

find . \! -path './dependencies/*' -type f \( -name '*.hpp' -o -name '*.h' -o -name '*.cpp' -o -name '*.c' \) \
    | xargs clang-format18 -i

@jwrober
Copy link
Collaborator Author

jwrober commented Dec 12, 2024

Ok I need to revert that last commit. We have a chicken and egg problem. I need the action to update first and then update the code after its committed

This reverts commit 688e583.

Undo last commit
@jwrober
Copy link
Collaborator Author

jwrober commented Dec 12, 2024

I'm going to start over. Closing

@jwrober jwrober closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update clang-format
3 participants