Support handshake data validator #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
添加握手验证hook
processPacket ，添加校验握手数据
新增WithHandshakeValidator 方法
修正‘=’缺失
lonng
reviewed
Dec 8, 2020
cluster/handler.go
Outdated
| @@ -252,6 +252,12 @@ func (h *LocalHandler) handle(conn net.Conn) { | |||
| func (h *LocalHandler) processPacket(agent *agent, p *packet.Packet) error { | |||
| switch p.Type { | |||
| case packet.Handshake: | |||
|
|
|||
lonng
reviewed
Dec 8, 2020
internal/env/env.go
Outdated
Comment on lines
53
to
54
|
|
||
|
|
lonng
reviewed
Dec 8, 2020
internal/env/env.go
Outdated
| @@ -38,6 +38,7 @@ var ( | |||
| CheckOrigin func(*http.Request) bool // check origin when websocket enabled | |||
| Debug bool // enable Debug | |||
| WSPath string // WebSocket path(eg: ws://127.0.0.1/WSPath) | |||
| HandshakeValidator func([]byte) error // When you need to verify the custom data of the handshake request | |||
lonng
reviewed
Dec 8, 2020
internal/env/env.go
Outdated
| Serializer = protobuf.NewSerializer() | ||
|
|
|
Format Code Success |
|
@NicholasChan1025 Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix: #68
解决issue68 自定义握手数据验证，验证失败则握手失败