Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some bugs #84

Merged
merged 5 commits into from
Sep 6, 2022
Merged

fix some bugs #84

merged 5 commits into from
Sep 6, 2022

Conversation

zlonglin
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@@ -244,3 +244,10 @@ func SetDictionary(dict map[string]uint16) {
codes[code] = r
}
}

func GetDictionary() (map[string]uint16, bool) {
if len(routes) <= 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value of len() will not be less than 0

@gsw945 gsw945 merged commit 7699d53 into lonng:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants