Fix for limiting logins list length

[dgvirtual]

(Codeigniter Model does not implement limit() metod

[lonnieezell]

The Model class doesn't directly, but it can use most of the functions from the query builder chained like that. Were you running into an actual error with this?

[dgvirtual]

The Model class doesn't directly, but it can use most of the functions from the query builder chained like that. Were you running into an actual error with this?

Using limit() does not produce an error, but it does not work either, it has no effect (on CI 4.3.3, php 7.4).

[dgvirtual]

@lonnieezell, I did a rebase for this PR, so now it passes tests. Please consider it as well. It is only minor improvement, but does limit the otherwise endless list of recent logins (https://www.codeigniter.com/user_guide/models/model.html#findall)

[lonnieezell]

Good call. Thanks!

[kenjis]

Oh, the the query builder limit(20) is overwritten by $limit of findAll()!

[dgvirtual]

Explains why limit() neither fails nor has any effect...

[dgvirtual]

If all is fine, could someone merge this into develop please? @lonnieezell ?

[dgvirtual]

@lonnieezell , let's finish this trivial change.