Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete src/actions/mparticle directory #462

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jakeaustin
Copy link
Contributor

Removing mParticle action as this integration is no longer supported by mParticle.

Please also confirm if/what additional action must be taken in order to remove this action from Looker's UIs.

Removing mParticle action as this integration is no longer supported by mParticle.
@drstrangelooker drstrangelooker changed the title Delete src/actions/mparticle directory fix: Delete src/actions/mparticle directory Mar 20, 2022
@drstrangelooker
Copy link
Collaborator

@jakeaustin In order contribute to Google open source projects you need to submit a Google Contributor License Agreement. You can do that here: https://cla.developers.google.com/. Thanks.

@jakeaustin
Copy link
Contributor Author

@jakeaustin In order contribute to Google open source projects you need to submit a Google Contributor License Agreement. You can do that here: https://cla.developers.google.com/. Thanks.

@drstrangelooker I will see if I can sign the agreement on behalf of my employer.

This action was originally developed by a third party and has been deprecated by mParticle - we are seeking to remove it from Looker's Action hub to avoid any client confusion. Is there a team within Looker that I can coordinate with on this?

@drstrangelooker
Copy link
Collaborator

This action was originally developed by a third party and has been deprecated by mParticle - we are seeking to remove it from Looker's Action hub to avoid any client confusion. Is there a team within Looker that I can coordinate with on this?

@phillipperalez would you handle this?

@phillipperalez
Copy link
Collaborator

phillipperalez commented Mar 23, 2022

I've checked usages and this is fine to delete. I can take this to own and remove

@phillipperalez phillipperalez self-requested a review March 24, 2022 15:27
@phillipperalez phillipperalez self-requested a review March 24, 2022 15:27
Copy link
Collaborator

@phillipperalez phillipperalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to need to remove mparticle from the index.ts file as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants