fix: updates helppanel tests and removes others #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #49 |
bryans99
previously approved these changes
May 6, 2021
bryans99
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for adding that extension context code. I moved it over to a wrapper function we can reuse.
I ran into a whole bunch of trouble trying to get d3 to play nicely with jest and react-testing-library. I chose to start working on because I thought jest would have access to the resultant svg, but that doesn't look like the case.
jsdom/jsdom#300
The answer I was able to find was to test the individual accessors. That doesn't make a lot of sense to me, as it's what Typescript is doing. And given my intention to eliminate d3 control of dom, doesn't seem efficient.
I removed the snapshot tests because they weren't really testing anything as shallow renders.
I can address by typing the svg. This is what I've proposed, and will work towards in medium term. In short term, the most important test targets are:
As well as improving the integration tests and diagram generation tests, which I feel better about.
I want to merge #47 , #49 , and this, check & update integration tests, and then cut a Marketplace release. Will work on the above items in future PRs, blocking net new work.