fix: add a test to additional query param required bug (#741)

* add a test to additional query param required bug

* use new URL with default base url

Co-authored-by: John Kaster <kaster@google.com>

packages/sdk-rtl/src/paging.spec.ts

@@ -197,6 +197,32 @@ describe('paging', () => {
       expect(actual.options?.timeout).toEqual(99)
     })
 
+    it('do not throw error without other params', async () => {
+      const actual = await pager(sdk, () =>
+        mockRawResponseSuccess(
+          transport,
+          mockedRows,
+          mockRawResponse('/api/4.0/alerts/search')
+        )
+      )
+      expect(actual).toBeDefined()
+      expect(actual.limit).toEqual(-1)
+      expect(actual.offset).toEqual(-1)
+    })
+
+    it('works without other query params', async () => {
+      const actual = await pager(sdk, () =>
+        mockRawResponseSuccess(
+          transport,
+          mockedRows,
+          mockRawResponse('/api/4.0/alerts/search?limit=3&offset=0')
+        )
+      )
+      expect(actual).toBeDefined()
+      expect(actual.limit).toEqual(3)
+      expect(actual.offset).toEqual(0)
+    })
+
     it('works on relative url', async () => {
       const actual = await pager(sdk, () =>
         mockRawResponseSuccess(

packages/sdk-rtl/src/paging.ts

@@ -373,7 +373,7 @@ export class Paging<TSuccess extends ILength, TError>
   }
 
   parse(raw: IRawResponse): IPager<TSuccess, TError> {
-    const params = new URLSearchParams(raw.url)
+    const params = new URL(raw.url, 'http://default').searchParams
     this.limit = Paging.paramDefault(params.get('limit'), -1)
     this.offset = Paging.paramDefault(
       params.get('offset'),