protect against webpack 5 removing Buffer

looker-open-source · Oct 26, 2021 · 23df8b4 · 23df8b4
1 parent bbf465c
commit 23df8b4
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/sdk-rtl/src/transport.ts b/packages/sdk-rtl/src/transport.ts
@@ -439,9 +439,13 @@ function bufferString(val: any) {
   } catch (e: any) {
     // Supremely ugly hack. If we get here, we must be in Node (or IE 11, but who cares about that?)
     // Node requires an import from `util` for TextDecoder to be found BUT it "just has" Buffer unless WebPack messes us up
-    if (val instanceof Buffer) {
-      result = Buffer.from(val).toString(utf8)
-    } else {
+    try {
+      if (val instanceof Buffer) {
+        result = Buffer.from(val).toString(utf8)
+      } else {
+        result = JSON.stringify(val)
+      }
+    } catch (err: any) {
       // The fallback logic here will at least give us some information about the error being thrown
       result = JSON.stringify(val)
     }