-
Notifications
You must be signed in to change notification settings - Fork 192
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: adds editor functionality to CodeDisplay (#615)
* adds basic editor * adds editor styling progress * removes type change * updates components * adds revisions * removes unused prop * removes Span for span * remove unneeded reference to older version of @looker/components-test-utils * cleans up @looker/code-editor * flips transparent condition * replaces old name * fixes package.json Co-authored-by: Bryn Ryans <bryn.ryans@looker.com>
- Loading branch information
Showing
26 changed files
with
230 additions
and
718 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 0 additions & 61 deletions
61
packages/api-explorer/src/components/DocCode/utils.spec.ts
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| MIT License | ||
| Copyright (c) 2021 Looker Data Sciences, Inc. | ||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
| */ | ||
| import React from 'react' | ||
| import { renderWithTheme } from '@looker/components-test-utils' | ||
| import userEvent from '@testing-library/user-event' | ||
| import { screen } from '@testing-library/react' | ||
|
|
||
| import { CodeEditor } from './CodeEditor' | ||
| import { pythonTestCode } from './test-data' | ||
|
|
||
| describe('CodeEditor', () => { | ||
| const setState = jest.fn() | ||
| const useStateSpy = jest.spyOn(React, 'useState') | ||
| useStateSpy.mockImplementation(() => [pythonTestCode, setState]) | ||
|
|
||
| test('it syntax highlights', () => { | ||
| renderWithTheme( | ||
| <CodeEditor onChange={setState} code={pythonTestCode} language="python" /> | ||
| ) | ||
| expect(screen.getByText('all_lookml_models').closest('span')).toHaveClass( | ||
| 'function' | ||
| ) | ||
| expect(screen.getByText('def').closest('span')).toHaveClass('keyword') | ||
| expect( | ||
| screen | ||
| .getByText('# GET /lookml_models -> Sequence[models.LookmlModel]') | ||
| .closest('span') | ||
| ).toHaveClass('comment') | ||
| }) | ||
| test('it is edittable', () => { | ||
| renderWithTheme( | ||
| <CodeEditor onChange={setState} code={pythonTestCode} language="python" /> | ||
| ) | ||
| const editPattern = '# This is the new code' | ||
| const input = screen | ||
| .getByRole('code-editor') | ||
| .getElementsByClassName('npm__react-simple-code-editor__textarea')[0] | ||
| userEvent.paste(input, editPattern) | ||
| expect(setState).toHaveBeenCalledWith(pythonTestCode + editPattern) | ||
| }) | ||
| }) |
Oops, something went wrong.