-
Notifications
You must be signed in to change notification settings - Fork 192
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Handle Go SDK 204 no responses correctly (#1193)
Changes copied from approved PR from forked repo #1074 Original commit message: I added status code handling in the Go SDK to deal with delete endpoints' response body. In Looker API, delete endpoints call returns empty response body with status code 204 when the API call is succeeded. Such API call will be failed with EOF error in the current implementation because of reading empty response body. Co-authored-by: hirohito-sasakawa <hirohito-sasakawa@m3.com> Co-authored-by: hirosassa <hiro.sassa@gmail.com>
- Loading branch information
1 parent
051cf86
commit ba7ded8
Showing
2 changed files
with
64 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters