fix: change visconfig types to reflect new getter (#1350)

* Fix types for VisualizationConfigImpl --------- Co-authored-by: Ryan Dunlavy <rdunlavy@google.com>
looker-open-source · Aug 14, 2023 · c7648d9 · c7648d9
1 parent 90f3f5f
commit c7648d9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/extension-sdk/src/connect/visualization/types.ts b/packages/extension-sdk/src/connect/visualization/types.ts
@@ -98,6 +98,7 @@ export interface VisualizationConfig {
   queryFieldDimensions: Dimension[]
   queryFieldTableCalculations: TableCalculation[]
   queryFieldPivots: PivotConfig[]
+  visConfig: RawVisConfig
 }
 
 export interface QueryResponse {

diff --git a/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts b/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts
@@ -92,8 +92,8 @@ class VisualizationConfigImpl implements VisualizationConfig {
     this._visConfig = visConfig
   }
 
-  get visConfig(): RawVisConfig | undefined {
-    return this._visConfig
+  get visConfig(): RawVisConfig {
+    return this._visConfig || {}
   }
 
   get queryFieldMeasures(): Measure[] {