-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: oauth support in APIX when embedded in another app #1198
Conversation
API Explore embedded in the developer portal was not calculating application paths correctly
const appConfig = `{ | ||
"client_guid": "looker.api-explorer", | ||
"redirect_uri": "${(window as any).location.origin}/oauth", | ||
const appConfig = `// client_guid=${client_id} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like Prism can correctly highlight this comment, so that's a bonus
Typescript Tests 6 files 56 suites 4m 41s ⏱️ Results for commit 2c5796c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks for getting this sorted!
@@ -104,7 +104,7 @@ export const fullify = (uri: string, baseUrl: string): string => { | |||
return url.toString() | |||
} | |||
/** | |||
* parse spec url into version and name for api_spec cccall | |||
* parse spec url into version and name for api_spec call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙀
Fixed a variety of path assumptions for the React app and extended OAuthScene to be more flexible and configurable