fix: oauth support in APIX when embedded in another app #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Explore embedded in the developer portal was not calculating application paths correctly
jkaster
commented
Oct 28, 2022
| const appConfig = `{ | ||
| "client_guid": "looker.api-explorer", | ||
| "redirect_uri": "${(window as any).location.origin}/oauth", | ||
| const appConfig = `// client_guid=${client_id} |
There was a problem hiding this comment.
looks like Prism can correctly highlight this comment, so that's a bonus
Typescript Tests 6 files 56 suites 4m 41s ⏱️ Results for commit 2c5796c. |
josephaxisa
approved these changes
Oct 28, 2022
| @@ -104,7 +104,7 @@ export const fullify = (uri: string, baseUrl: string): string => { | |||
| return url.toString() | |||
| } | |||
| /** | |||
| * parse spec url into version and name for api_spec cccall | |||
| * parse spec url into version and name for api_spec call | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a variety of path assumptions for the React app and extended OAuthScene to be more flexible and configurable