Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a test to additional query param required bug #741

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

annguy3n
Copy link
Collaborator

@annguy3n annguy3n commented Jul 7, 2021

Address query params parsing bug for pagination. See tests for bug info.

@google-cla google-cla bot added the cla: yes label Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Typescript Tests

    2 files    48 suites   25s ⏱️
137 tests 136 ✔️ 0 💤 1 ❌
310 runs  308 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 63d99d1.

@annguy3n annguy3n changed the title add a test to additional query param required bug fix: add a test to additional query param required bug Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Typescript Tests

    7 files    76 suites   3m 39s ⏱️
163 tests 160 ✔️   3 💤 0 ❌
568 runs  556 ✔️ 12 💤 0 ❌

Results for commit 0e7e97a.

@annguy3n annguy3n requested a review from jkaster July 7, 2021 23:55
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Typescript Tests

    7 files  ±0    76 suites  ±0   3m 46s ⏱️ +9s
163 tests +2  160 ✔️ +2    3 💤 ±0  0 ❌ ±0 
568 runs  +6  556 ✔️ +6  12 💤 ±0  0 ❌ ±0 

Results for commit 2e94405. ± Comparison against base commit 3ed6af7.

@annguy3n annguy3n merged commit 0cbe656 into main Jul 8, 2021
@annguy3n annguy3n deleted the an/strange-parsing-bug branch July 8, 2021 01:34
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants