fix: Sidenav selection #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabs in sidenav were not being synced with history. Now if tab selected, history is updated. If page is reloaded, tabs are synced to current history. If link is clicked that updates sidenav panel, panel is updated accordingly.
bryans99
requested review from
jkaster,
drstrangelooker,
josephaxisa,
fabio-looker and
jeremytchang
1. SideNav now handles URL for diff scene (additional path parameter). 2. initDefaultSpecState now validates specKey from path. If invalid falls back to 4.0. 3. DiffScene now validates specKey(s) from url. If invalid falls back to default. 4. TagScene now changes routes in a useEffect. Also returns an empty node if methods are not available (can happens when URL contains not valid method name after SideBar changes URL)
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs in sidenav were not being synced with history. Now if tab selected,
history is updated. If page is reloaded, tabs are synced to current
history. If link is clicked that updates sidenav panel, panel is updated
accordingly.