Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sidenav selection #831

Merged
merged 2 commits into from
Sep 22, 2021
Merged

fix: Sidenav selection #831

merged 2 commits into from
Sep 22, 2021

Commits on Sep 21, 2021

  1. fix: Sidenav selection

    Tabs in sidenav were not being synced with history. Now if tab selected,
    history is updated. If page is reloaded, tabs are synced to current
    history. If link is clicked that updates sidenav panel, panel is updated
    accordingly.
    bryans99 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    0f72d22 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Additional fixes:

    1. SideNav now handles URL for diff scene (additional path parameter).
    2. initDefaultSpecState now validates specKey from path. If invalid
    falls back to 4.0.
    3. DiffScene now validates specKey(s) from url. If invalid falls back to
    default.
    4. TagScene now changes routes in a useEffect. Also returns an empty
    node if methods are not available (can happens when URL contains not valid
    method name after SideBar changes URL)
    bryans99 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    bc4ff72 View commit details
    Browse the repository at this point in the history