Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 21.16 release #859

Merged
merged 6 commits into from
Oct 18, 2021
Merged

feat: 21.16 release #859

merged 6 commits into from
Oct 18, 2021

Conversation

drstrangelooker
Copy link
Collaborator

I haven't verified yet but I wanted to let what ci run on it.

@google-cla google-cla bot added the cla: yes label Oct 14, 2021
@drstrangelooker drstrangelooker changed the title 21.16 release feat: 21.16 release Oct 14, 2021
@github-actions
Copy link
Contributor

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 187f26b.

@github-actions
Copy link
Contributor

Python Tests

  10 files    10 suites   2m 22s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
788 runs  788 ✔️ 0 💤 0 ❌

Results for commit 187f26b.

@joeldodge79 joeldodge79 self-requested a review October 15, 2021 13:17
@joeldodge79
Copy link
Contributor

looks like prettier doesn't like the generated typescript code - time for a bugfix: https://github.com/looker-open-source/sdk-codegen/pull/859/checks?check_run_id=3900851843

@jkaster
Copy link
Contributor

jkaster commented Oct 15, 2021

Ah. Our prettier config changed after what's hard coded into codegen I guess? Need to see if we can load the same config settings for Codegen. I think yarn fix may unblock this PR though.

@github-actions
Copy link
Contributor

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 1e19d30.

@github-actions
Copy link
Contributor

Python Tests

    9 files      9 suites   1m 55s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit 1e19d30.

@github-actions
Copy link
Contributor

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 0f14c41.

@github-actions
Copy link
Contributor

Python Tests

    9 files      9 suites   2m 3s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit 0f14c41.

@drstrangelooker
Copy link
Collaborator Author

CAn someone explain what is going on here...

~/sdk-codegen (21.16-release) $ npx eslint 'packages/**/*.ts{,x}' --cache --quiet

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/funcs.ts
  10754:42  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/methods.ts
  10096:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/methodsInterface.ts
  7267:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/models.ts
  10975:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/streams.ts
  11597:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/funcs.ts
  12154:42  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/methods.ts
  11414:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/methodsInterface.ts
  8197:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/models.ts
  12206:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/streams.ts
  13106:2  error  Insert `⏎`  prettier/prettier

✖ 10 problems (10 errors, 0 warnings)
  10 errors and 0 warnings potentially fixable with the `--fix` option.

# edit the files to add the carriage return at end

~/sdk-codegen (21.16-release) $ vim packages/sdk/src/*/*.ts
10 files to edit
~/sdk-codegen (21.16-release) $ npx eslint 'packages/**/*.ts{,x}' --cache --quiet

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/funcs.ts
  10755:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/methods.ts
  10097:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/methodsInterface.ts
  7268:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/models.ts
  10976:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/3.1/streams.ts
  11598:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/funcs.ts
  12155:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/methods.ts
  11415:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/methodsInterface.ts
  8198:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/models.ts
  12207:1  error  Delete `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/streams.ts
  13107:1  error  Delete `⏎`  prettier/prettier

✖ 10 problems (10 errors, 0 warnings)
  10 errors and 0 warnings potentially fixable with the `--fix` option.

@joeldodge79
Copy link
Contributor

CAn someone explain what is going on here...

what do you call a dear with no eyes?

@drstrangelooker
Copy link
Collaborator Author

drstrangelooker commented Oct 16, 2021 via email

@drstrangelooker
Copy link
Collaborator Author

@josephaxisa do you have any pointers here? Prettier is insisting that I have a newline at the end of the last line of 10 files. When I added the newline, it complained that I have the newline and wanted me to delete it.

So the before and after looks like this

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/streams.ts
  13106:2  error  Insert `⏎`  prettier/prettier

/usr/local/google/home/drstrangelove/sdk-codegen/packages/sdk/src/4.0/streams.ts
  13107:1  error  Delete `⏎`  prettier/prettier

@josephaxisa
Copy link
Contributor

@drstrangelooker running yarn fix seems to fix the problem (i.e.yarn lint:es no longer complains) but the issue should be fixed at the source otherwise this will be a recurring issue every time the bindings are generated. I think the issue is in the reformatter but @jkaster would know best. In the meantime, can you file a bug?

@github-actions
Copy link
Contributor

Python Tests

    9 files      9 suites   2m 6s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit dc2c46e.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   4m 7s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs  543 ✔️ 12 💤 0 ❌

Results for commit dc2c46e.

jkaster
jkaster approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drstrangelooker drstrangelooker merged commit 0b4385c into main Oct 18, 2021
@drstrangelooker drstrangelooker deleted the 21.16-release branch October 18, 2021 16:52
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

@joeldodge79 joeldodge79 Awaiting requested review from joeldodge79

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drstrangelooker @joeldodge79 @jkaster @josephaxisa