-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release main #1032
chore: release main #1032
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1d758fe
to
0eab326
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0eab326
to
55c268e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think v3 of release-please-action is broken for our use-cases. Can we revert to the previous version of the action?
@@ -1,20 +1,20 @@ | |||
{ | |||
".": "2.2.0", | |||
".": "2.3.0", | |||
"packages/api-explorer": "0.9.29", | |||
"packages/code-editor": "0.1.19", | |||
"packages/extension-api-explorer": "22.2.1", | |||
"packages/extension-sdk": "22.2.0", | |||
"packages/extension-sdk-react": "22.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this version of release-please doesn't quite work for us yet. This package (and many others) should have bumped to 22.4.0 but they didn't
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@looker/extension-sdk-react", | |||
"version": "22.2.1", | |||
"version": "22.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a) this should have bumped to 22.4.0 and
b) it should have at least shown up in the manifest.
Go Tests 7 files 7 suites 5m 54s ⏱️ Results for commit 55c268e. |
…blish CI (#1030) - Updated release-please to latest v3 from v2 that contains the needed functionality for releasing Go SDK. The breaking changes should not affect us: https://github.com/google-github-actions/release-please-action/releases/tag/v3.0.0 - Setup release-please config to release Go SDK at v0 only.-- To release Go SDK at v1 and above requires automated editing of the module name in go.mod during SDK generation or when release-please creates a release PR. Release-please gi thub issue: googleapis/release-please#1344 -- The repo tag must be in the exact format of "go/vX.X.X". So package-name and tag-separator in release-please-config.json are set accordingly - Setup release-please-manifest to point go sdk to 0.0.1. 0.0.0 is automatically bumped to 1.0.0 ignoring the "pre-major" release-please configs. - Setup a go publish github action that publishes go module to go proxy based off the new tag - Updated go.mod and go.sum with go mod tidy which cleans up dependencies
Python Tests 12 files 12 suites 3m 1s ⏱️ Results for commit 55c268e. |
APIX Tests 1 files 78 suites 3m 55s ⏱️ Results for commit 55c268e. |
Typescript Tests 8 files 77 suites 5m 26s ⏱️ Results for commit 55c268e. |
I think v3 may be bugged, and isn't applying the |
@joeldodge79 Trying to repro the issue in my test repo, and then will write up an issue with release-please. |
Closing because after rolling back from v3 to v2, v2 release-please created a different chore:release main pr here |
🤖 I have created a release beep boop
sdk-codegen-all: 2.3.0
2.3.0 (2022-03-24)
Features
Bug Fixes
looker_sdk: 22.4.0
22.4.0 (2022-03-24)
Features
go: 0.0.2
0.0.2 (2022-03-24)
Features
Bug Fixes
@looker/api-explorer: 0.9.30
Dependencies
@looker/code-editor: 0.1.20
Dependencies
@looker/extension-api-explorer: 22.2.2
Dependencies
@looker/extension-sdk: 22.2.1
Dependencies
@looker/extension-sdk-react: 22.2.2
Dependencies
@looker/extension-utils: 0.1.7
Dependencies
hackathon: 22.4.0
22.4.0 (2022-03-24)
Features
Dependencies
@looker/run-it: 0.9.30
Dependencies
sdk: 22.4.0
22.4.0 (2022-03-24)
Features
@looker/sdk-codegen: 21.5.1
Dependencies
sdk-codegen-scripts: 21.3.1
21.3.1 (2022-03-24)
Bug Fixes
Dependencies
sdk-node: 22.4.0
22.4.0 (2022-03-24)
Features
Bug Fixes
Dependencies
sdk-rtl: 21.3.2
21.3.2 (2022-03-24)
Bug Fixes
@looker/wholly-sheet: 0.5.26
Dependencies
This PR was generated with Release Please. See documentation.