feat: Implemented Go SDK env var handling #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added unit tests for it that will leave existing environment variables undisturbed. (Will store env vars before test and restore env vars after test)
Go Tests 2 files 2 suites 24s ⏱️ Results for commit 5830729. |
jkaster
approved these changes
Feb 9, 2022
| } | ||
| if v, present := os.LookupEnv(verifySslEnvKey); present { | ||
| s := strings.ToLower(v) | ||
| settings.VerifySsl = s == "true" || s == "t" || s == "1" || s == "y" || s == "yes" |
There was a problem hiding this comment.
fwiw other SDKs have either an isBool() or defaultBool() type of helper function. In this case, I think we want to default settings.VerifySSL to true
There was a problem hiding this comment.
Oh good catch! I will fix.
There was a problem hiding this comment.
I just reread the spec. My logic is correct. It already has verifySSL default to true at line 49. Only if the env variable is set does it change.
true, t, yes, y, or 1 (case insensitive) to enable SSL verification. Any other value is treated as false. Defaults to true if not set.
This comment has been minimized.
This comment has been minimized.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added unit tests for it that will leave existing environment variables undisturbed. (Will store env vars before test and restore env vars after test)