Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update go codegen to set object as interface{} #980

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

jeremytchang
Copy link
Collaborator

@jeremytchang jeremytchang commented Feb 11, 2022

Currently the Go SDK Models will break on build because the type in params is set to *struct which is not valid. For now set object to interface{}. Could do map[string]interface{} in the future.

This change is needed to get integration tests to work.

Generated 4.0 Go model too.

Generated and updated 4.0 Go model too.
@github-actions
Copy link
Contributor

Go Tests

  2 files  ±0    2 suites  ±0   24s ⏱️ ±0s
30 tests ±0  30 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
60 runs  ±0  60 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2b58daf. ± Comparison against base commit 571a817.

@github-actions
Copy link
Contributor

Codegen Tests

    1 files    17 suites   24s ⏱️
397 tests 383 ✔️ 14 💤 0 ❌
398 runs  384 ✔️ 14 💤 0 ❌

Results for commit 2b58daf.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this mean the Go v3 folder is no longer being generated, too? Was that an incidental cleanup you got resolved to get the generator running correctly?

@github-actions
Copy link
Contributor

Go Tests

  2 files    2 suites   24s ⏱️
30 tests 30 ✔️ 0 💤 0 ❌
60 runs  60 ✔️ 0 💤 0 ❌

Results for commit ef07718.

@github-actions
Copy link
Contributor

Codegen Tests

    1 files  ±0    18 suites  ±0   29s ⏱️ -2s
403 tests ±0  389 ✔️ ±0  14 💤 ±0  0 ❌ ±0 
404 runs  ±0  390 ✔️ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit ef07718. ± Comparison against base commit 5e9a221.

@jeremytchang
Copy link
Collaborator Author

@jkaster The Go model generation issue stemmed from sdk-codegen script package.json version was incorrect. I had made Jax's change locally. https://github.com/looker-open-source/sdk-codegen/pull/976/files#diff-4b80bf2b50cec2975b7466079f3acd1355591534fd0adc381a257267a682b5d9

@jeremytchang jeremytchang merged commit 007989d into main Feb 14, 2022
@jeremytchang jeremytchang deleted the jc/go_codegen branch February 14, 2022 19:07
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants