-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update go codegen to set object as interface{} #980
Conversation
Generated and updated 4.0 Go model too.
Codegen Tests 1 files 17 suites 24s ⏱️ Results for commit 2b58daf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this mean the Go v3
folder is no longer being generated, too? Was that an incidental cleanup you got resolved to get the generator running correctly?
Go Tests 2 files 2 suites 24s ⏱️ Results for commit ef07718. |
@jkaster The Go model generation issue stemmed from sdk-codegen script package.json version was incorrect. I had made Jax's change locally. https://github.com/looker-open-source/sdk-codegen/pull/976/files#diff-4b80bf2b50cec2975b7466079f3acd1355591534fd0adc381a257267a682b5d9 |
Currently the Go SDK Models will break on build because the type in params is set to
*struct
which is not valid. For now set object tointerface{}
. Could domap[string]interface{}
in the future.This change is needed to get integration tests to work.
Generated 4.0 Go model too.