-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: another TS SDK error handling tweak #873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…again # Conflicts: # packages/api-explorer/src/components/SideNav/SideNav.spec.tsx # packages/api-explorer/src/components/SideNav/SideNav.tsx # packages/api-explorer/src/components/SideNav/searchUtils.ts # packages/api-explorer/src/reducers/search/reducer.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm
APIX Tests 1 files ±0 77 suites ±0 2m 35s ⏱️ -34s For more details on these failures, see this check. Results for commit b7917ec. ± Comparison against base commit bff67d4. |
Codegen Tests 1 files 6 suites 24s ⏱️ Results for commit 85d50d4. |
Typescript Tests 6 files 75 suites 4m 9s ⏱️ Results for commit 85d50d4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!!
Some dependency changes broke low-level error handling for
@looker/sdk-rtl
in some scenarios. This hopefully fixes the various ways and means of processing the error condition