Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: another TS SDK error handling tweak #873

Merged
merged 6 commits into from
Oct 26, 2021
Merged

Conversation

jkaster
Copy link
Contributor

@jkaster jkaster commented Oct 26, 2021

Some dependency changes broke low-level error handling for @looker/sdk-rtl in some scenarios. This hopefully fixes the various ways and means of processing the error condition

@github-actions
Copy link
Contributor

Typescript Tests

    6 files  ±0    75 suites  ±0   4m 48s ⏱️ +30s
167 tests ±0  163 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
555 runs  ±0  543 ✔️ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit bbf465c. ± Comparison against base commit 59124bd.

josephaxisa
josephaxisa previously approved these changes Oct 26, 2021
Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

Typescript Tests

    6 files  ±0    75 suites  ±0   3m 57s ⏱️ -21s
167 tests ±0  163 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
555 runs  ±0  543 ✔️ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 23df8b4. ± Comparison against base commit 59124bd.

…again

# Conflicts:
#	packages/api-explorer/src/components/SideNav/SideNav.spec.tsx
#	packages/api-explorer/src/components/SideNav/SideNav.tsx
#	packages/api-explorer/src/components/SideNav/searchUtils.ts
#	packages/api-explorer/src/reducers/search/reducer.spec.ts
josephaxisa
josephaxisa previously approved these changes Oct 26, 2021
Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@github-actions
Copy link
Contributor

APIX Tests

    1 files  ±0    77 suites  ±0   2m 35s ⏱️ -34s
317 tests ±0  303 ✔️  - 1  13 💤 ±0  1 ❌ +1 
333 runs  ±0  319 ✔️  - 1  13 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit b7917ec. ± Comparison against base commit bff67d4.

@github-actions
Copy link
Contributor

APIX Tests

    1 files  ±0    77 suites  ±0   2m 35s ⏱️ -34s
317 tests ±0  304 ✔️ ±0  13 💤 ±0  0 ❌ ±0 
333 runs  ±0  320 ✔️ ±0  13 💤 ±0  0 ❌ ±0 

Results for commit 85d50d4. ± Comparison against base commit bff67d4.

@github-actions
Copy link
Contributor

Codegen Tests

  1 files    6 suites   24s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit 85d50d4.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   4m 9s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs  543 ✔️ 12 💤 0 ❌

Results for commit 85d50d4.

Copy link
Collaborator

@bryans99 bryans99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

@jkaster jkaster merged commit 1c04952 into main Oct 26, 2021
@jkaster jkaster deleted the jk/ts_error_handling_again branch October 26, 2021 19:37
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants