fix: Updated hackathon readme landing page path #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to match what is running in production
jkaster
reviewed
Nov 5, 2021
packages/hackathon/README.md
Outdated
| @@ -60,7 +81,7 @@ application: hackathon_app { | |||
| Remember to add a model to the project that has a valid connection. | |||
|
|
|||
| ## Specific steps to `yarn` | |||
| 1. run `yarn install` in sdk-codegen | |||
| 1. run `yarn install` in sdk-codegen | |||
| 2. run `yarn build` in sdk-codgen | |||
There was a problem hiding this comment.
Suggested change
| 2. run `yarn build` in sdk-codgen | |
| 2. run `yarn build` in sdk-codegen |
| @@ -50,7 +50,7 @@ const HACKATHON_USER_ATTR_NAME = 'hackathon' // case sensitive | |||
| const HACKATHON_USER_ATTR_LABEL = 'Hackathon' | |||
| const HACKATHON_GROUP_PREFIX = 'Looker_Hack: ' | |||
| const LANDING_PAGE_ATTR_NAME = 'landing_page' | |||
| const LANDING_PAGE_PATH = '/extensions/hackathon::hackathon_app' | |||
| const LANDING_PAGE_PATH = '/extensions/hackathon::hackathon' | |||
There was a problem hiding this comment.
Is the user registration script setting this path for the default landing page? Are all existing registrants going to have their homepage updated to this new URL?
There was a problem hiding this comment.
The user registration group creates a group for hackathon 2021. The script assigns a role to the group that defines the landing page. When users are added, they are added to the group and thus get the landing page attribute overwritten by the group role.
So technically, this change shouldn't be needed. And i can jsut change our manifest.kml to rename to hackathon_app. But i want to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to match what is running in production