Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated hackathon readme landing page path #893

Merged
merged 3 commits into from
Nov 5, 2021
Merged

fix: Updated hackathon readme landing page path #893

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
038fc2c
fix: Updated hackathon readme landing page path
jeremytchang Nov 5, 2021
cf55d54
Update hackathon readme
jeremytchang Nov 5, 2021
d61ea3b
Added create-looker-extension utility
jeremytchang Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions packages/hackathon/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ To configure your access token server, see the instructions in the [access token
Until the Hackathon extension is available via the Looker Marketplace, a Hackathon manifest needs to be used. This manifest should have:

```lookml
project_name: "hackathon_app"
application: hackathon_app {
project_name: "hackathon"
application: hackathon {
label: "Hackathon"
url: "https://localhost:8080/dist/bundle.js"
# file: "bundle.js"
Expand All @@ -46,8 +46,29 @@ application: hackathon_app {
use_clipboard: no
external_api_urls: ["http://localhost:8081/*", "https://sheets.googleapis.com/*"]
core_api_methods: [
"me", "all_roles", "all_user_attributes", "delete_user_attribute", "create_user_attribute", "search_groups",
"search_users", "user_roles", "role_users", "user_attribute_user_values"
"me",
"all_roles",
"all_user_attributes",
"delete_user_attribute",
"create_user_attribute",
"search_groups",
"search_users",
"user_roles",
"role_users",
"user_attribute_user_values",
"search_roles",
"create_group",
"set_role_groups",
"set_user_attribute_group_values",
"set_user_attribute_user_value",
"create_user_credentials_email",
"send_user_credentials_email_password_reset",
"create_user_credentials_api3",
"add_group_user",
"update_user",
"create_user",
"search_groups_with_roles",
"role_groups"
]
oauth2_urls: []
scoped_user_attributes: ["sheet_id", "token_server_url"]
Expand All @@ -60,7 +81,7 @@ application: hackathon_app {
Remember to add a model to the project that has a valid connection.

## Specific steps to `yarn`
1. run `yarn install` in sdk-codegen
1. run `yarn install` in sdk-codegen
2. run `yarn build` in sdk-codgen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. run `yarn build` in sdk-codgen
2. run `yarn build` in sdk-codegen

3. run `yarn start` in examples/access_token_server
4. run `yarn dev:hack` in sdk-codegen to start the development server and connect to the extension
Expand Down
2 changes: 1 addition & 1 deletion packages/hackathon/src/data/add_user/sagas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const HACKATHON_USER_ATTR_NAME = 'hackathon' // case sensitive
const HACKATHON_USER_ATTR_LABEL = 'Hackathon'
const HACKATHON_GROUP_PREFIX = 'Looker_Hack: '
const LANDING_PAGE_ATTR_NAME = 'landing_page'
const LANDING_PAGE_PATH = '/extensions/hackathon::hackathon_app'
const LANDING_PAGE_PATH = '/extensions/hackathon::hackathon'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the user registration script setting this path for the default landing page? Are all existing registrants going to have their homepage updated to this new URL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user registration group creates a group for hackathon 2021. The script assigns a role to the group that defines the landing page. When users are added, they are added to the group and thus get the landing page attribute overwritten by the group role.
So technically, this change shouldn't be needed. And i can jsut change our manifest.kml to rename to hackathon_app. But i want to be safe.


function* parseCsvSaga(action: ReturnType<typeof parseCsv>): SagaIterator {
try {
Expand Down