-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
looker-sdk 21.20.0 throws TypeError for python 3.9.10 #944
Comments
Relevant discussion in |
We're experiencing this issue as well and it's blocking our release via GHA. |
@ps-jmorrow @rowedonalde Can you pin python at <= 3.9.9 as a workaround till I can take a look? |
That worked as a workaround, thanks. |
I think for now we need to restrict to |
…causes build failure
Have you all been able to pull in latest with the PR change and confirm the issue is fixed? |
I just got some details from @joeldodge79 Any idea how much of an effort this might be? |
probably a few hours to check if switching to
and then another few hours to update so maybe a day or two's worth of work? |
fixes #944 the main fix here is switching from `cattr.register_structure_hook` to `cattr.register_structure_hook_func`. I re-organized some of the code in an effort to reproduce the issue in the test_serialize.py suite but I could not reproduce there, only in integration tests. Now that it's a function, we don't need a generated hook per type. I further isolated the converter usage switching the serializing to use each 31/40 dedicated converter. I also switched to the newer GenConverter. setup testing against python 3.10
fixes #944 the main fix here is switching from `cattr.register_structure_hook` to `cattr.register_structure_hook_func`. I re-organized some of the code in an effort to reproduce the issue in the test_serialize.py suite but I could not reproduce there, only in integration tests. Now that it's a function, we don't need a generated hook per type. I further isolated the converter usage switching the serializing to use each 31/40 dedicated converter. I also switched to the newer GenConverter. setup testing against python 3.10
Due to a change in Python's
functools
module that was included in the update from 3.9.9->3.9.10,looker_sdk
breaks on import. The error seems to be through thecattr
dependency:The text was updated successfully, but these errors were encountered: