Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make Go SDK parse response by result type #1021

Merged
merged 3 commits into from
Mar 23, 2022
Merged

fix: Make Go SDK parse response by result type #1021

merged 3 commits into from
Mar 23, 2022

Commits on Mar 23, 2022

  1. fix: Go SDK parses response by result type 

    Currently go sdk model generation doesn't support union type for responses like
RunQuery. So we cannot parse according to Content Type Header. For now, parse
based off model type.

We need to update sdk model generation to use interface{}
for union types, and then use Content Type Header to parse response accordingly.
This will break downstream dependencies.

- Added additional integration tests around queries looks and
  dashboards.
- Parse response based of type defined in go sdk models, the result type
- Added unit tests
- Return error body in addition to error status code.
    @jeremytchang
    jeremytchang committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    ba7347e View commit details
    Browse the repository at this point in the history

  2. Added git issue in comment

    @jeremytchang
    jeremytchang committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    875d64e View commit details
    Browse the repository at this point in the history

  3. Added png/svg integration tests and updated integration tests to pass… 

    …ing with new 22.4
    @jeremytchang
    jeremytchang committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    7e07cfa View commit details
    Browse the repository at this point in the history