fix: encodeParam returned [object Object] for object types #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the object value is stringified JSON
Typescript Tests 5 files 74 suites 2m 9s ⏱️ For more details on these failures, see this check. Results for commit 43c91ca. |
Typescript Tests 8 files 77 suites 5m 10s ⏱️ Results for commit 93a74ed. |
joeldodge79
approved these changes
Apr 6, 2022
bryans99
reviewed
Apr 7, 2022
| @@ -379,8 +380,12 @@ export type Values = { [key: string]: any } | null | undefined | |||
| export function encodeParam(value: any) { | |||
| if (value instanceof Date) { | |||
| value = value.toISOString() | |||
| } else if (value instanceof DelimArray) { | |||
There was a problem hiding this comment.
This looks so familiar. I thought we'd fixed it
There was a problem hiding this comment.
at least we've fixed it now
jkaster
added a commit
that referenced
this pull request
Apr 7, 2022
for #1047 when it lands Co-authored-by: John Kaster <kaster@google.com>
This comment has been minimized.
This comment has been minimized.
jkaster
pushed a commit
that referenced
this pull request
Apr 7, 2022
🤖 I have created a release \*beep\* \*boop\* --- <details><summary>sdk-codegen-all: 2.3.1</summary> ### Bug Fixes * encodeParam returned [object Object] for object types ([#1047](https://www.github.com/looker-open-source/sdk-codegen/issues/1047)) ([eccc1db](https://www.github.com/looker-open-source/sdk-codegen/commit/eccc1dbb3d64f36e6a06d71a1c3da37d972abd3a)) </details> <details><summary>@looker/sdk-rtl: 21.3.2</summary> ### Bug Fixes * encodeParam returned [object Object] for object types ([#1047](https://www.github.com/looker-open-source/sdk-codegen/issues/1047)) ([eccc1db](https://www.github.com/looker-open-source/sdk-codegen/commit/eccc1dbb3d64f36e6a06d71a1c3da37d972abd3a)) </details> <details><summary>@looker/sdk: 22.4.1</summary></details> <details><summary>@looker/sdk-codegen: 21.5.1</summary></details> <details><summary>@looker/extension-sdk: 22.4.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.4.0 to ^22.4.1 </details> <details><summary>@looker/sdk-node: 22.4.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.4.0 to ^22.4.1 </details> <details><summary>@looker/code-editor: 0.1.20</summary> ### Dependencies * The following workspace dependencies were updated * devDependencies * @looker/sdk-codegen bumped from ^21.5.0 to ^21.5.1 </details> <details><summary>@looker/extension-sdk-react: 22.4.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from ^22.4.0 to ^22.4.1 * @looker/sdk bumped from ^22.4.0 to ^22.4.1 </details> <details><summary>@looker/sdk-codegen-scripts: 21.3.2</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.4.0 to ^22.4.1 * @looker/sdk-codegen bumped from ^21.5.0 to ^21.5.1 * @looker/sdk-node bumped from ^22.4.0 to ^22.4.1 </details> <details><summary>@looker/wholly-sheet: 0.5.27</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.4.0 to ^22.4.1 * devDependencies * @looker/sdk-node bumped from ^22.4.0 to ^22.4.1 </details> <details><summary>@looker/extension-utils: 0.1.8</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from ^22.4.0 to ^22.4.1 * @looker/extension-sdk-react bumped from ^22.4.0 to ^22.4.1 </details> <details><summary>@looker/hackathon: 22.4.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from ^0.1.19 to ^0.1.20 * @looker/extension-sdk bumped from ^22.4.0 to ^22.4.1 * @looker/extension-sdk-react bumped from ^22.4.0 to ^22.4.1 * @looker/extension-utils bumped from ^0.1.7 to ^0.1.8 * @looker/sdk bumped from ^22.4.0 to ^22.4.1 * @looker/wholly-sheet bumped from ^0.5.26 to ^0.5.27 </details> <details><summary>@looker/run-it: 0.9.31</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from ^0.1.19 to ^0.1.20 * @looker/extension-utils bumped from ^0.1.7 to ^0.1.8 * @looker/sdk bumped from ^22.4.0 to ^22.4.1 * @looker/sdk-codegen bumped from ^21.5.0 to ^21.5.1 </details> <details><summary>@looker/api-explorer: 0.9.31</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-utils bumped from ^0.1.7 to ^0.1.8 * @looker/code-editor bumped from ^0.1.19 to ^0.1.20 * @looker/run-it bumped from ^0.9.30 to ^0.9.31 * @looker/sdk bumped from ^22.4.0 to ^22.4.1 * @looker/sdk-codegen bumped from ^21.5.0 to ^21.5.1 * devDependencies * @looker/sdk-codegen-scripts bumped from ^21.3.1 to ^21.3.2 * @looker/sdk-node bumped from ^22.4.0 to ^22.4.1 </details> <details><summary>@looker/extension-api-explorer: 22.4.1</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from ^0.9.30 to ^0.9.31 * @looker/extension-sdk-react bumped from ^22.4.0 to ^22.4.1 * @looker/extension-utils bumped from ^0.1.7 to ^0.1.8 * @looker/run-it bumped from ^0.9.30 to ^0.9.31 * @looker/sdk bumped from ^22.4.0 to ^22.4.1 * @looker/sdk-codegen bumped from ^21.5.0 to ^21.5.1 </details> This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@looker/sdk-rtlwas encoding object values likeas
and now the value is JSON stringified instead