test: Diff scene e2e tests #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er tests time out
APIX Tests 1 files 78 suites 3m 41s ⏱️ Results for commit ca67b9d. |
josephaxisa
reviewed
May 5, 2022
| // text: 'Looker API 4.0 Reference', | ||
| // }) | ||
| // await expect(page).toClick('input[value="4.0"]') | ||
| // await Promise.all([ |
There was a problem hiding this comment.
is this intentionally commented out? if yes, do we have a ticket to track its fix?
There was a problem hiding this comment.
Yes, it was broken when I merged main back in, along with two others that I was able to fix.
I just created this issue: b/231742409
josephaxisa
approved these changes
May 6, 2022
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following requested e2e tests:
Additoinally, three previous e2e tests were failing (partially due to out of date tests from before 4.0 GA release). Two of them have been fixed, and one which was proving cumbersome has been commented out for the time being.