Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: copy link button for search #1120

Merged
merged 42 commits into from
Aug 2, 2022
Merged

feat: copy link button for search #1120

merged 42 commits into from
Aug 2, 2022

Commits on Jul 14, 2022

  1. WIP search sharing in URL

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    0b4e578 View commit details
    Browse the repository at this point in the history

  2. URL search param will update search box in sidenav

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    95436a4 View commit details
    Browse the repository at this point in the history

  3. Avoid string | null errors

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    dcb882a View commit details
    Browse the repository at this point in the history

  4. WIP search query back button and slow input box

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    850b64b View commit details
    Browse the repository at this point in the history

  5. Functional query routing with accurate browser history, WIP testing

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    40caab1 View commit details
    Browse the repository at this point in the history

  6. Removed comment

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    754c84f View commit details
    Browse the repository at this point in the history

  7. Added navigation utility file, helper function for pushing routing wi… 

    …thout losing parameters
    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    de28036 View commit details
    Browse the repository at this point in the history

  8. Functional with spec and search and method/types chosen

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    d26203e View commit details
    Browse the repository at this point in the history

  9. WIP: mocking ApiExplorer.tsx useEffect on location search

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    1a013f1 View commit details
    Browse the repository at this point in the history

  10. Quick addition

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    02afef8 View commit details
    Browse the repository at this point in the history

  11. WIP: getting testing to work.

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    1c41c03 View commit details
    Browse the repository at this point in the history

  12. WIP comments

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    a8a0451 View commit details
    Browse the repository at this point in the history

  13. WIP: working SideNav tests

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    671d3dc View commit details
    Browse the repository at this point in the history

  14. Tests working, need to now add final few

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    281eb27 View commit details
    Browse the repository at this point in the history

  15. New properly working navigate function with unit tests, working exist… 

    …ing tests, WIP: testing URL sharing
    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    1467970 View commit details
    Browse the repository at this point in the history

  16. Refactoring some comments out, fixed to pass tests, removed APIExplor… 

    …er.spec.tsx
    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    1f5ac10 View commit details
    Browse the repository at this point in the history

  17. Minor refactoring to add readability/cleanliness

    @patnir41
    patnir41 committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    2a664cd View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Per feedback from John and Joseph, WIP: navigation hook

    @patnir41
    patnir41 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    6cb274a View commit details
    Browse the repository at this point in the history

  2. Created custom navigation hook, replaced history pushes where necessary

    @patnir41
    patnir41 committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    516c106 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Added changes per Bryn's comments, new buildNavigationPath

    @patnir41
    patnir41 committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    0ed839a View commit details
    Browse the repository at this point in the history

  2. updated edit for buildNavigationPath

    @patnir41
    patnir41 committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    addc668 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Merge branch 'main' into search-query-route-update

    @jkaster
    jkaster authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    aaba996 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into search-query-route-update

    @jkaster
    jkaster authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    bfdaf8f View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Changes per Joseph's feedback

    @patnir41
    patnir41 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    1f2857e View commit details
    Browse the repository at this point in the history

  2. Added location.search as dependency in SideNav useEffect

    @patnir41
    patnir41 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    7c3124e View commit details
    Browse the repository at this point in the history

  3. Copy button functional within inner search box; need to migrate to se… 

    …parate file
    @patnir41
    patnir41 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    e69bb82 View commit details
    Browse the repository at this point in the history

  4. Proper CopyLinkButton file set up

    @patnir41
    patnir41 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0f5211f View commit details
    Browse the repository at this point in the history

  5. URL icon updated with recent PR branch functional, less style component

    @patnir41
    patnir41 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    7276e0a View commit details
    Browse the repository at this point in the history

  6. Unit test for CopyLinkButton

    @patnir41
    patnir41 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    25d2d6c View commit details
    Browse the repository at this point in the history

  7. Unit tests + functionality fixed, using Span

    @patnir41
    patnir41 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    e4c7919 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into patnir41/url-sharing-icon

    @patnir41
    patnir41 authored Jul 19, 2022
    Configuration menu
    Copy the full SHA
    a4017d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Added unit test to SideNav, refactored code

    @patnir41
    patnir41 committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    bd4ced9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Updates to CopyLink button design

    @patnir41
    patnir41 committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    e637edb View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Documentation in CopyLinkWrapper

    @patnir41
    patnir41 committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    6215995 View commit details
    Browse the repository at this point in the history

  2. Documentation edits

    @patnir41
    patnir41 committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    1b4dd9c View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. Support for extension framework (need to confirm)

    @patnir41
    patnir41 committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    1ea89c0 View commit details
    Browse the repository at this point in the history

  2. Have adaptor available in spec test

    @patnir41
    patnir41 committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    f7cba5c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Support for extension framework with appropriate tests

    @patnir41
    patnir41 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    88cb459 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Change to interface making optional location param for both frameworks

    @patnir41
    patnir41 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    8fe07ed View commit details
    Browse the repository at this point in the history

  2. Refactoring extensionAdaptor

    @patnir41
    patnir41 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c1f3dd4 View commit details
    Browse the repository at this point in the history

  3. extensionAdaptor test refactor

    @patnir41
    patnir41 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    faf8838 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Merge branch 'main' into patnir41/url-sharing-icon

    @patnir41
    patnir41 authored Aug 2, 2022
    Configuration menu
    Copy the full SHA
    6a0f597 View commit details
    Browse the repository at this point in the history