fix: various path navigation issues #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk selection was broken on the developer portal because some scenes weren't using the react dom `location` for `location.pathname`
added funSDK syntax for TypeScript `makeTheCall()`
Codegen Tests 1 files 18 suites 42s ⏱️ Results for commit 8d23c8f. |
fabio-looker
approved these changes
Oct 17, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jkaster
pushed a commit
that referenced
this pull request
Oct 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- <details><summary>sdk-codegen-all: 2.11.0</summary> ### Features * generate SDKs for Looker 22.18 ([#1191](https://www.github.com/looker-open-source/sdk-codegen/issues/1191)) ([6d487be](https://www.github.com/looker-open-source/sdk-codegen/commit/6d487be80e89bda6feea446130ad2c318eb61d43)) ### Bug Fixes * various path navigation issues ([#1190](https://www.github.com/looker-open-source/sdk-codegen/issues/1190)) ([e73da3d](https://www.github.com/looker-open-source/sdk-codegen/commit/e73da3d39960cb528947c21202318b84d586ce1f)) </details> <details><summary>@looker/api-explorer: 0.9.40</summary> ### Bug Fixes * various path navigation issues ([#1190](https://www.github.com/looker-open-source/sdk-codegen/issues/1190)) ([e73da3d](https://www.github.com/looker-open-source/sdk-codegen/commit/e73da3d39960cb528947c21202318b84d586ce1f)) ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from ^0.1.24 to ^0.1.25 * @looker/extension-utils bumped from ^0.1.16 to ^0.1.17 * @looker/run-it bumped from ^0.9.39 to ^0.9.40 * @looker/sdk bumped from ^22.16.0 to ^22.18.0 * @looker/sdk-codegen bumped from ^21.7.1 to ^21.7.2 * devDependencies * @looker/sdk-codegen-scripts bumped from ^21.4.5 to ^21.4.6 * @looker/sdk-node bumped from ^22.16.0 to ^22.18.0 </details> <details><summary>@looker/sdk: 22.18.0</summary> ### Features * generate SDKs for Looker 22.18 ([#1191](https://www.github.com/looker-open-source/sdk-codegen/issues/1191)) ([6d487be](https://www.github.com/looker-open-source/sdk-codegen/commit/6d487be80e89bda6feea446130ad2c318eb61d43)) </details> <details><summary>@looker/sdk-codegen: 21.7.2</summary> ### Bug Fixes * various path navigation issues ([#1190](https://www.github.com/looker-open-source/sdk-codegen/issues/1190)) ([e73da3d](https://www.github.com/looker-open-source/sdk-codegen/commit/e73da3d39960cb528947c21202318b84d586ce1f)) </details> <details><summary>looker_sdk: 22.18.0</summary> ### Features * generate SDKs for Looker 22.18 ([#1191](https://www.github.com/looker-open-source/sdk-codegen/issues/1191)) ([6d487be](https://www.github.com/looker-open-source/sdk-codegen/commit/6d487be80e89bda6feea446130ad2c318eb61d43)) </details> <details><summary>@looker/extension-sdk: 22.18.0</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.16.0 to ^22.18.0 </details> <details><summary>@looker/sdk-node: 22.18.0</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.16.0 to ^22.18.0 </details> <details><summary>@looker/code-editor: 0.1.25</summary> ### Dependencies * The following workspace dependencies were updated * devDependencies * @looker/sdk-codegen bumped from ^21.7.1 to ^21.7.2 </details> <details><summary>@looker/extension-sdk-react: 22.18.0</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from ^22.16.0 to ^22.18.0 * @looker/sdk bumped from ^22.16.0 to ^22.18.0 </details> <details><summary>@looker/sdk-codegen-scripts: 21.4.6</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.16.0 to ^22.18.0 * @looker/sdk-codegen bumped from ^21.7.1 to ^21.7.2 * @looker/sdk-node bumped from ^22.16.0 to ^22.18.0 </details> <details><summary>@looker/wholly-sheet: 0.5.36</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from ^22.16.0 to ^22.18.0 * devDependencies * @looker/sdk-node bumped from ^22.16.0 to ^22.18.0 </details> <details><summary>@looker/extension-utils: 0.1.17</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from ^22.16.0 to ^22.18.0 * @looker/extension-sdk-react bumped from ^22.16.0 to ^22.18.0 * @looker/code-editor bumped from ^0.1.24 to ^0.1.25 </details> <details><summary>@looker/hackathon: 22.18.0</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from ^0.1.24 to ^0.1.25 * @looker/extension-sdk bumped from ^22.16.0 to ^22.18.0 * @looker/extension-sdk-react bumped from ^22.16.0 to ^22.18.0 * @looker/extension-utils bumped from ^0.1.16 to ^0.1.17 * @looker/sdk bumped from ^22.16.0 to ^22.18.0 * @looker/wholly-sheet bumped from ^0.5.35 to ^0.5.36 </details> <details><summary>@looker/run-it: 0.9.40</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/code-editor bumped from ^0.1.24 to ^0.1.25 * @looker/extension-utils bumped from ^0.1.16 to ^0.1.17 * @looker/sdk bumped from ^22.16.0 to ^22.18.0 * @looker/sdk-codegen bumped from ^21.7.1 to ^21.7.2 </details> <details><summary>@looker/extension-api-explorer: 22.18.0</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from ^0.9.39 to ^0.9.40 * @looker/extension-sdk bumped from ^22.16.0 to ^22.18.0 * @looker/extension-sdk-react bumped from ^22.16.0 to ^22.18.0 * @looker/extension-utils bumped from ^0.1.16 to ^0.1.17 * @looker/run-it bumped from ^0.9.39 to ^0.9.40 * @looker/sdk bumped from ^22.16.0 to ^22.18.0 * @looker/sdk-codegen bumped from ^21.7.1 to ^21.7.2 </details> This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locationforlocation.pathname, which caused the path to include/api/explorerwhen it shouldn't havemakeTheCall()that now shows in RunIt