Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keep all body parameters toggle in API Explorer requests #1245

Merged
merged 36 commits into from
Feb 17, 2023
Merged

feat: keep all body parameters toggle in API Explorer requests #1245

merged 36 commits into from
Feb 17, 2023

Conversation

jkaster
Copy link
Contributor

@jkaster jkaster commented Feb 6, 2023

Adds a checkbox to the request form to keep all body parameters for an API request. By default, all "empty" parameters are stripped from the body for an API request

jkaster and others added 20 commits January 25, 2023 17:48
@jkaster
feat: allow sending request body as is in APIX
d8c8501 
The request form has a toggle for sending the request body as is

The `trimInputs` function is updated to include a `keepBody` parameter that defaults to false
@jkaster
WIP keep body checkbox
73a078f
@jkaster
WIP keep body checkbox
88767ba
@jkaster
WIP badly broken branch
b5c7067 
More will be broken before it's fixed
@jkaster
WIP currently 11 build errors
2b6f66d
@jkaster
WIP currently 10 build errors
1db4030
@jkaster
WIP currently 5 build errors
fc5f145
@jkaster
WIP then there were 4
99a74a0
@jkaster
WIP now 3
4f6798c
@josephaxisa
wip: address @looker/redux build errors
b953356 
fixed the last 4 errors, now we have 27 new ones
@jkaster
added bin/rebuild script for web stack
c317aa7
@jkaster
added bin/rebuild script for web stack
9ade3cb
@jkaster
cleaned up some build
a658ddc
@jkaster
still stuck on markdown, but moving foward
f5772e1
@josephaxisa
update webpack-cli and webpack-dev-server
e00d738
@josephaxisa
fix: type issue with MDParagraph
c2315da
@jkaster
fixing sdk calls tab for keepBody
0e01190
@jkaster
updated ts-node
d0626f5
@bryans99
fix build?
29c13dd
@jkaster
makeTheCall now preserves empty objects
7b94d5e 
also fixed Kotlin makeTheCall delimArray generation. Dunno how it got broken with the unit test failing
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit ff571d1.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Codegen Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit ff571d1.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

APIX Tests

  1 files    7 suites   3s ⏱️
23 tests 22 ✔️ 0 💤 1 ❌
26 runs  25 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 88d5097.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Codegen Tests

    1 files    18 suites   40s ⏱️
423 tests 406 ✔️ 17 💤 0 ❌

Results for commit 88d5097.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Typescript Tests

    6 files    56 suites   4m 31s ⏱️
200 tests 196 ✔️   4 💤 0 ❌
494 runs  478 ✔️ 16 💤 0 ❌

Results for commit 88d5097.

@github-actions
Copy link
Contributor

Typescript Tests

0 files   -     6  0 suites   - 56   0s ⏱️ - 5m 59s
0 tests  - 200  0 ✔️  - 196  0 💤  -   4  0 ❌ ±0 
0 runs   - 494  0 ✔️  - 478  0 💤  - 16  0 ❌ ±0 

Results for commit ec230d9. ± Comparison against base commit 4a8ef9d.

This pull request removes 200 tests. 
AccessToken defaults with empty token ‑ AccessToken defaults with empty token
AccessToken has a 10 second lag time for expiration ‑ AccessToken has a 10 second lag time for expiration
AccessToken is active with full token ‑ AccessToken is active with full token
ApiMethods full path with auth is just full path ‑ ApiMethods full path with auth is just full path
ApiMethods full path without auth is just full path ‑ ApiMethods full path without auth is just full path
ApiMethods path not prefixed if base url not set ‑ ApiMethods path not prefixed if base url not set
ApiMethods relative path with auth is api path ‑ ApiMethods relative path with auth is api path
ApiMethods relative path without auth is just base ‑ ApiMethods relative path without auth is just base
Browser session authenticate causes authentication ‑ Browser session authenticate causes authentication
Browser session getToken is mocked ‑ Browser session getToken is mocked
…

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit ec230d9.

@github-actions
Copy link
Contributor

Codegen Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit ec230d9.

@github-actions
Copy link
Contributor

Typescript Tests

0 files   -     6  0 suites   - 56   0s ⏱️ - 5m 59s
0 tests  - 200  0 ✔️  - 196  0 💤  -   4  0 ❌ ±0 
0 runs   - 494  0 ✔️  - 478  0 💤  - 16  0 ❌ ±0 

Results for commit c3527a1. ± Comparison against base commit 4a8ef9d.

This pull request removes 200 tests. 
AccessToken defaults with empty token ‑ AccessToken defaults with empty token
AccessToken has a 10 second lag time for expiration ‑ AccessToken has a 10 second lag time for expiration
AccessToken is active with full token ‑ AccessToken is active with full token
ApiMethods full path with auth is just full path ‑ ApiMethods full path with auth is just full path
ApiMethods full path without auth is just full path ‑ ApiMethods full path without auth is just full path
ApiMethods path not prefixed if base url not set ‑ ApiMethods path not prefixed if base url not set
ApiMethods relative path with auth is api path ‑ ApiMethods relative path with auth is api path
ApiMethods relative path without auth is just base ‑ ApiMethods relative path without auth is just base
Browser session authenticate causes authentication ‑ Browser session authenticate causes authentication
Browser session getToken is mocked ‑ Browser session getToken is mocked
…

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit c3527a1.

@github-actions
Copy link
Contributor

Codegen Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit c3527a1.

@github-actions
Copy link
Contributor

Typescript Tests

0 files   -     6  0 suites   - 56   0s ⏱️ - 5m 59s
0 tests  - 200  0 ✔️  - 196  0 💤  -   4  0 ❌ ±0 
0 runs   - 494  0 ✔️  - 478  0 💤  - 16  0 ❌ ±0 

Results for commit 360c21e. ± Comparison against base commit 4a8ef9d.

This pull request removes 200 tests. 
AccessToken defaults with empty token ‑ AccessToken defaults with empty token
AccessToken has a 10 second lag time for expiration ‑ AccessToken has a 10 second lag time for expiration
AccessToken is active with full token ‑ AccessToken is active with full token
ApiMethods full path with auth is just full path ‑ ApiMethods full path with auth is just full path
ApiMethods full path without auth is just full path ‑ ApiMethods full path without auth is just full path
ApiMethods path not prefixed if base url not set ‑ ApiMethods path not prefixed if base url not set
ApiMethods relative path with auth is api path ‑ ApiMethods relative path with auth is api path
ApiMethods relative path without auth is just base ‑ ApiMethods relative path without auth is just base
Browser session authenticate causes authentication ‑ Browser session authenticate causes authentication
Browser session getToken is mocked ‑ Browser session getToken is mocked
…

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 360c21e.

@github-actions
Copy link
Contributor

Codegen Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 360c21e.

@github-actions
Copy link
Contributor

Typescript Tests

0 files   -     6  0 suites   - 56   0s ⏱️ - 5m 59s
0 tests  - 200  0 ✔️  - 196  0 💤  -   4  0 ❌ ±0 
0 runs   - 494  0 ✔️  - 478  0 💤  - 16  0 ❌ ±0 

Results for commit 3887b0c. ± Comparison against base commit 4a8ef9d.

This pull request removes 200 tests. 
AccessToken defaults with empty token ‑ AccessToken defaults with empty token
AccessToken has a 10 second lag time for expiration ‑ AccessToken has a 10 second lag time for expiration
AccessToken is active with full token ‑ AccessToken is active with full token
ApiMethods full path with auth is just full path ‑ ApiMethods full path with auth is just full path
ApiMethods full path without auth is just full path ‑ ApiMethods full path without auth is just full path
ApiMethods path not prefixed if base url not set ‑ ApiMethods path not prefixed if base url not set
ApiMethods relative path with auth is api path ‑ ApiMethods relative path with auth is api path
ApiMethods relative path without auth is just base ‑ ApiMethods relative path without auth is just base
Browser session authenticate causes authentication ‑ Browser session authenticate causes authentication
Browser session getToken is mocked ‑ Browser session getToken is mocked
…

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 3887b0c.

@github-actions
Copy link
Contributor

Typescript Tests

    1 files   -     5    22 suites   - 34   49s ⏱️ - 5m 10s
163 tests  -   37  163 ✔️  -   33  0 💤  -   4  0 ❌ ±0 
181 runs   - 313  181 ✔️  - 297  0 💤  - 16  0 ❌ ±0 

Results for commit 5a0e6f2. ± Comparison against base commit 4a8ef9d.

This pull request removes 37 tests. 
ExtensionProvider component does not render loading ‑ ExtensionProvider component does not render loading
ExtensionProvider component renders content with MemoryRouter ‑ ExtensionProvider component renders content with MemoryRouter
ExtensionProvider component renders content without MemoryRouter ‑ ExtensionProvider component renders content without MemoryRouter
ExtensionProvider component renders initialization error ‑ ExtensionProvider component renders initialization error
ExtensionProvider component renders loading ‑ ExtensionProvider component renders loading
ExtensionProvider component renders ‑ ExtensionProvider component renders
ExtensionProvider2 component renders ‑ ExtensionProvider2 component renders
ExtensionProvider40 component renders ‑ ExtensionProvider40 component renders
LookerNodeSDK Dashboard endpoints create and update dashboard ‑ LookerNodeSDK Dashboard endpoints create and update dashboard
LookerNodeSDK Dashboard endpoints search_dashboards ‑ LookerNodeSDK Dashboard endpoints search_dashboards
…

@github-actions
Copy link
Contributor

Codegen Tests

    1 files    18 suites   1m 45s ⏱️
423 tests 406 ✔️ 17 💤 0 ❌

Results for commit 5a0e6f2.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    86 suites   6m 39s ⏱️
409 tests 383 ✔️ 26 💤 0 ❌
429 runs  403 ✔️ 26 💤 0 ❌

Results for commit 5a0e6f2.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    86 suites   5m 42s ⏱️
409 tests 383 ✔️ 26 💤 0 ❌
429 runs  403 ✔️ 26 💤 0 ❌

Results for commit a224710.

@github-actions
Copy link
Contributor

Codegen Tests

    1 files    18 suites   1m 43s ⏱️
423 tests 406 ✔️ 17 💤 0 ❌

Results for commit a224710.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files  ±0    56 suites  ±0   9m 33s ⏱️ + 3m 34s
200 tests ±0  196 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
494 runs  ±0  478 ✔️ ±0  16 💤 ±0  0 ❌ ±0 

Results for commit a224710. ± Comparison against base commit 4a8ef9d.

@jkaster jkaster merged commit 043ed3f into main Feb 17, 2023
@jkaster jkaster deleted the jk/keep_body branch February 17, 2023 19:43
Merged
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephaxisa josephaxisa josephaxisa approved these changes

@bryans99 bryans99 Awaiting requested review from bryans99

@jeremytchang jeremytchang Awaiting requested review from jeremytchang

@treshugart treshugart Awaiting requested review from treshugart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkaster @josephaxisa @bryans99 @jeremytchang