feat: embed url service #1297
Merged
feat: embed url service #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkaster
reviewed
Apr 12, 2023
| Dashboard = 'DASHBOARD', | ||
| } | ||
|
|
||
| const THEMABLE_CONTENT: ContentType[] = [ |
There was a problem hiding this comment.
I presume this is from a standard we use somewhere on the frontend for constant names?
There was a problem hiding this comment.
hmm, it's how I am used to doing it. I believe I saw @bryans99 doing it similarly as well. I can look through a style guide to make sure though
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't think Looker follows the Google style guide for TypeScript
jkaster
approved these changes
Apr 13, 2023
Merged
josephaxisa
added a commit
that referenced
this pull request
Apr 14, 2023
josephaxisa
added a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.