Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: singleton factory and theme service #1298

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

josephaxisa
Copy link
Contributor

No description provided.

jkaster
jkaster previously approved these changes Apr 13, 2023
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions but nothing blocking approval

packages/embed-services/src/ThemeService.spec.ts Outdated Show resolved Hide resolved
packages/embed-services/src/ServiceFactory.spec.ts Outdated Show resolved Hide resolved
packages/embed-services/src/ThemeService.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick work! Looks great.

@josephaxisa josephaxisa merged commit 18af00b into main Apr 13, 2023
@josephaxisa josephaxisa deleted the jax/theme-service branch April 13, 2023 00:22
This was referenced May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants