-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate SDKs for Looker 23.14 #1347
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
csharp/rtl/Constants.cs
Outdated
@@ -59,9 +59,9 @@ public struct Constants | |||
internal static readonly Regex ContentPatternBinary = new Regex(MatchModeBinary, | |||
RegexOptions.CultureInvariant | RegexOptions.IgnoreCase | RegexOptions.Compiled); | |||
|
|||
public const string DefaultApiVersion = "4.0"; | |||
public const string DefaultApiVersion = "3.1"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have been auto-generated from an old looker.ini
setting. Need to fix this
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey @fabio-looker , since this is not yet merged I was wondering if it'd be possible to get this change in as well for the 23.14 version #1348 that was just merged. Would be helpful for our partners at Sisu. |
Jeremy assures me that release-please will automatically take it. We are hopefully close to merging this from Jeremy's run of SDK codegen because my local run is still reporting one unexpected test failure. |
Awesome, thanks Fabio |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release-As: 23.14.0
Release-As: 23.14.0
Release-As: 23.14.0
Release-As: 23.14.0
Release-As: 23.14.0
93d62da
to
e4a77d2
Compare
@fabio-looker You should be ready to go after the checks run. |
Python Tests 10 files 10 suites 1m 50s ⏱️ Results for commit e4a77d2. |
Go Tests 6 files 6 suites 9m 29s ⏱️ Results for commit e4a77d2. |
Release-As: 23.14.0