Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send message on visConfig extension update #1348

Merged
merged 2 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/extension-sdk/src/connect/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ export enum ExtensionRequestType {
* Visualization configuration data
*/
VIS_DEFAULT_CONFIG = 'VIS_DEFAULT_CONFIG',
/**
* Change visualization configuration after intial load
*/
VIS_CONFIG_UPDATE = 'VIS_CONFIG_UPDATE',
/**
* Tile add error messages
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,4 +152,56 @@ describe('VisualizationSDK', () => {
sdk.updateVisData(visualizationData)
expect(sdk.visualizationData).toBeUndefined()
})

it('updates visConfig remotely and queryResponse locally when provided', () => {
const sdk = new VisualizationSDKImpl(api)
expect(sdk.visualizationData).toBeUndefined()
const visConfig: RawVisConfig = {
query_fields: {
measures: [{ a: 'a' }],
dimensions: [{ a: 'b' }],
table_calculations: [{ a: 'c' }],
pivots: [{ a: 'd' }],
},
}
const queryResponse: RawVisQueryResponse = {
data: [{ abc: { value: 'xyz' } }],
fields: {
measures: [{ a: 'a' }],
dimensions: [{ a: 'b' }],
table_calculations: [{ a: 'c' }],
pivots: [{ a: 'd' }],
measure_like: [{ a: 'e' }],
dimension_like: [{ a: 'f' }],
},
pivots: [],
}
const visualizationData: RawVisualizationData = {
visConfig,
queryResponse,
}
sdk.updateVisData(visualizationData)
expect(sdk.visualizationData).toEqual(visualizationData)
expect(sdk.visConfig.visConfig).toEqual(visConfig)
expect(api.send).toHaveBeenCalledWith('VIS_CONFIG_UPDATE', {
updatedConfig: visConfig,
})

const updatedVisConfig = {
...visConfig,
background_color: 'blue',
} as RawVisConfig
const updatedVisualizationData: RawVisualizationData = {
visConfig: updatedVisConfig,
queryResponse,
}

sdk.updateVisData(updatedVisualizationData)
expect(sdk.visualizationData).toEqual(updatedVisualizationData)
expect(sdk.visConfig.visConfig).toEqual(updatedVisConfig)
expect(api.send).toHaveBeenCalledWith('VIS_CONFIG_UPDATE', {
updatedConfig: updatedVisConfig,
})
expect(sdk.visualizationData).toEqual(updatedVisualizationData)
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ class VisualizationConfigImpl implements VisualizationConfig {
this._visConfig = visConfig
}

get visConfig(): RawVisConfig | undefined {
return this._visConfig
}

get queryFieldMeasures(): Measure[] {
return this._visConfig?.query_fields?.measures || []
}
Expand Down Expand Up @@ -124,10 +128,13 @@ export class VisualizationSDKImpl implements VisualizationSDK {
// Should never happen.
if (this.hostApi.isDashboardMountSupported) {
this.visualizationData = visualizationData
if (this._visConfig) {
if (this.visConfig && this._visConfig) {
this._visConfig.update(this.visualizationData.visConfig)
this.hostApi.send(ExtensionRequestType.VIS_CONFIG_UPDATE, {
ryandunlavy marked this conversation as resolved.
Show resolved Hide resolved
updatedConfig: this.visualizationData.visConfig,
})
}
if (this._queryResponse) {
if (this.queryResponse && this._queryResponse) {
this._queryResponse.update(this.visualizationData.queryResponse)
bryans99 marked this conversation as resolved.
Show resolved Hide resolved
}
}
Expand Down
Loading