fix: remove search criteria selector and auto expand results #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldodge79
previously requested changes
Apr 9, 2021
josephaxisa
changed the title
|
Something else we'll have to add tests for when/before we have codecov 😉 |
josephaxisa
force-pushed
the
jax/search-criteria-selector
branch
from
f735797
to
8639366
Compare
@jkaster Unacceptable. I added search tests :) |
josephaxisa
changed the title
bryans99
reviewed
Apr 13, 2021
| const input = screen.getByLabelText('Search') | ||
| jest.spyOn(api, 'search') | ||
| await act(async () => { | ||
| /** Pasting to avoid triggering search multiple times */ |
There was a problem hiding this comment.
I don't understand the comment. Perhaps a little more clarity on why. Possibly because entering characters being entered one by results in search being triggered for each character?
Something like
Using ... triggers search multiple times. Use of paste avoids this
| @@ -70,6 +68,13 @@ const SideNavMethodsLayout: FC<MethodsProps> = ({ | |||
| if (_isOpen) history.push(`/${specKey}/methods/${tag}`) | |||
| } | |||
|
|
|||
| useEffect(() => { | |||
| const status = match | |||
There was a problem hiding this comment.
setIsOpen defaults to defaultOpen but you are modifying the value if the value of defaultOpen changes. Is defaultOpen a good name?
There was a problem hiding this comment.
We can find a better name for another PR
jkaster
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.