Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recursive search of direct type references #591

Merged
merged 2 commits into from
Apr 14, 2021
Merged

fix: recursive search of direct type references #591

merged 2 commits into from
Apr 14, 2021

Conversation

josephaxisa
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Apr 14, 2021
@josephaxisa josephaxisa changed the title fix: recursive search issue fix: recursive search of direct type references Apr 14, 2021
jkaster
jkaster requested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a debug error still in there

packages/sdk-codegen/src/sdkModels.ts Outdated Show resolved Hide resolved
jkaster
jkaster approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix works!

@jkaster jkaster merged commit 9af2e37 into main Apr 14, 2021
@jkaster jkaster deleted the jax/fix-search branch April 14, 2021 20:10
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Test Results

  1 files  ±0    6 suites  ±0   39s ⏱️ +6s
58 tests ±0  46 ✔️ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 9af2e37. ± Comparison against base commit 53a32eb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephaxisa @jkaster