Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add clipboard write capability to extension framework #603

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

bryans99
Copy link
Collaborator

No description provided.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see a granular example of adding a feature

@@ -63,7 +63,7 @@ describe('extension_host_api tests', () => {
console.error = originalConsoleError
})

const createHostApi = (initMessage = {}) => {
const createHostApi = (initMessage = {}, lookerVersion = '6.25.0') => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a very old fix-up you needed to check in?

@github-actions

This comment has been minimized.

@bryans99 bryans99 merged commit d6b52ea into main Apr 20, 2021
@bryans99 bryans99 deleted the brynryans/clipboard-write branch April 20, 2021 17:49
@github-actions
Copy link
Contributor

Test Results

    7 files    73 suites   3m 51s ⏱️
152 tests 152 ✔️ 0 💤 0 ❌
531 runs  531 ✔️ 0 💤 0 ❌

Results for commit d6b52ea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants