Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes deprecated object attribute reference #622

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

noahamac
Copy link
Contributor

Usage of the deprecated label attribute in these tests were causing the latest Api Explorer build to fail

@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@noahamac noahamac requested a review from jkaster April 22, 2021 02:11
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for fixing these tests, but of course we still need to fix the extension bundling script. Separate PR for that.

@jkaster jkaster merged commit 581b351 into main Apr 22, 2021
@jkaster jkaster deleted the noahamac/fix-gen-test-ref branch April 22, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants